Skip to content

Add 'Arc' keyword to --proxy-skip-range for Azure Arc private-link endpoints - #61

Merged
Tareesh21 merged 11 commits into
mainfrom
t_proxyskip
Aug 1, 2026
Merged

Add 'Arc' keyword to --proxy-skip-range for Azure Arc private-link endpoints#61
Tareesh21 merged 11 commits into
mainfrom
t_proxyskip

Conversation

@Tareesh21

@Tareesh21 Tareesh21 commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

This change introduces a Arc keyword for the --proxy-skip-range parameter of az connectedk8s connect and az connectedk8s update. When the keyword is supplied, the CLI automatically expands it to the Azure Arc private-link data-plane endpoints, removing the need
for customers to identify and specify these endpoints manually.

Behaviour

  • The Arc keyword expands to the following region-agnostic endpoints
    • .his.arc.azure.<cloud>
    • .dp.kubernetesconfiguration.azure.<cloud>
    • .guestconfiguration.azure.<cloud>
  • The <cloud> suffix is derived from the active cloud (public or sovereign).
  • Keyword matching is case-insensitive; arc, Arc, and ARC are all accepted.
  • All other entries supplied in --proxy-skip-range are preserved, and duplicate
    entries are removed.
  • No behaviour change when the keyword isn't passed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Tareesh21 and others added 3 commits July 23, 2026 09:35
@Tareesh21
Merge branch 'main' into t_proxyskip
571e68c
Sai Tareesh Reddy Eppeti
Revert "Bump Version"
5324e65 
This reverts commit 6c4f3d0.
Drops the 1.10.13 -> 1.10.14 version bump from the PR; the Arc
proxy-skip-range feature can be published under a batched release
bump instead.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aa3f5a60-e3b1-49b4-a4e5-5d656000d376
@Tareesh21
Merge branch 'main' into t_proxyskip
a361557
@Tareesh21

Tareesh21 commented Jul 29, 2026

Copy link
Copy Markdown
Author

E2E tests

  1. https://dev.azure.com/ClusterConfigurationAgent/E2ETests/_build/results?buildId=9861252&view=results
  2. https://dev.azure.com/ClusterConfigurationAgent/E2ETests/_build/results?buildId=9861226&view=results

jmccormick7
jmccormick7 reviewed Jul 30, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/_params.py
jianyunt
jianyunt reviewed Jul 30, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/custom.py
jianyunt
jianyunt reviewed Jul 30, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/custom.py
jianyunt
jianyunt reviewed Jul 30, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/_help.py
@jianyunt

jianyunt commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown 
  text: az connectedk8s connect -g resourceGroupName -n connectedClusterName --proxy-https https://proxy-url --proxy-http http://proxy-url --proxy-skip-range excludedIP,excludedCIDR,exampleCIDRfollowed,10.0.0.0/24

updating the sample by including Arc should be enough #Resolved

Refers to: src/connectedk8s/azext_connectedk8s/_help.py:28 in 6eadcf9. [](commit_id = 6eadcf9, deletion_comment = False)

jianyunt
jianyunt reviewed Jul 30, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/_help.py
jianyunt
jianyunt reviewed Jul 30, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/_constants.py
jianyunt
jianyunt reviewed Jul 30, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/_params.py Outdated
jianyunt
jianyunt reviewed Jul 30, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/tests/unittests/test_custom.py
Sai Tareesh Reddy Eppeti and others added 2 commits July 31, 2026 13:21
Sai Tareesh Reddy Eppeti
Extract Arc proxy-skip-range endpoints into a constant and simplify h…
d3d5f87 
…elp text

Move the Arc private-link endpoint suffixes into a shared Arc_Private_Link_Endpoints constant and consume it from get_arc_proxy_skip_range_endpoints (behavior unchanged). Simplify the --proxy-skip-range help text and fold the Arc keyword into the existing examples, dropping the dedicated private-link example blocks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sai Tareesh Reddy Eppeti
Add proxy test for the Arc keyword in --proxy-skip-range
cd629be 
Assert that 'az connectedk8s update --proxy-skip-range Arc' expands to the Azure Arc private-link endpoints in the agent noProxy value.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jianyunt
jianyunt reviewed Jul 31, 2026
View reviewed changes
Comment thread testing/test/configurations/Proxy.Tests.ps1
}

It 'Expands the Arc keyword in --proxy-skip-range to the Azure Arc private-link endpoints' {
az connectedk8s update -n $ENVCONFIG.arcClusterName -g $ENVCONFIG.resourceGroup --proxy-skip-range Arc

@jianyunt jianyunt Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

do we want to connect scenario too?

@Tareesh21 Tareesh21 Jul 31, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect and update both call the same function. Since we've already added the update scenario with Arc, adding a connect scenario here would just duplicate the same logic.

jianyunt
jianyunt reviewed Jul 31, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/tests/unittests/test_custom.py
jianyunt
jianyunt reviewed Jul 31, 2026
View reviewed changes
Comment thread src/connectedk8s/azext_connectedk8s/tests/unittests/test_custom.py

def test_expand_arc_keyword_usgov_cloud():
cmd = _proxy_cmd("https://login.microsoftonline.us")
out = expand_proxy_skip_range_keywords(cmd, "Arc")

@jianyunt jianyunt Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Arc")

Also add cases like

"Arc, arc", ==> "arc"

"Arc, .his.ARC.azure.com" ===> "arc, .his.arc.azure.com"

de-dup is needed

@Tareesh21 Tareesh21 Jul 31, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.
Now for "Arc, .his.ARC.azure.com" ===> "arc", because his.ARC.azure.com is one of the endpoints in "arc"

@jianyunt jianyunt Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

jianyunt
jianyunt approved these changes Jul 31, 2026
View reviewed changes

@jianyunt jianyunt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Tareesh21
Tareesh21 merged commit aa39de0 into main Aug 1, 2026
4 of 8 checks passed
@Tareesh21
Tareesh21 deleted the t_proxyskip branch August 1, 2026 00:09
jmccormick7 pushed a commit that referenced this pull request Aug 13, 2026
@Tareesh21 Sai Tareesh Reddy Eppeti
John McCormick
Add 'Arc' keyword to --proxy-skip-range for Azure Arc private-link en…
a3d92ad 
…dpoints (#61)

* Add 'Arc' keyword for --proxy-skip-range to expand Azure Arc private-link endpoints

* Add unit tests for Arc proxy-skip-range keyword expansion

* Add Arc keyword help text

* Bump Version

* Revert "Bump Version"

This reverts commit 6c4f3d0.
Drops the 1.10.13 -> 1.10.14 version bump from the PR; the Arc
proxy-skip-range feature can be published under a batched release
bump instead.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aa3f5a60-e3b1-49b4-a4e5-5d656000d376

* Text modify

* Extract Arc proxy-skip-range endpoints into a constant and simplify help text

Move the Arc private-link endpoint suffixes into a shared Arc_Private_Link_Endpoints constant and consume it from get_arc_proxy_skip_range_endpoints (behavior unchanged). Simplify the --proxy-skip-range help text and fold the Arc keyword into the existing examples, dropping the dedicated private-link example blocks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add proxy test for the Arc keyword in --proxy-skip-range

Assert that 'az connectedk8s update --proxy-skip-range Arc' expands to the Azure Arc private-link endpoints in the agent noProxy value.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Added dedup functionality and tests

---------

Co-authored-by: Sai Tareesh Reddy Eppeti <seppeti@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aa3f5a60-e3b1-49b4-a4e5-5d656000d376
jmccormick7 pushed a commit that referenced this pull request Aug 13, 2026
@Tareesh21 Sai Tareesh Reddy Eppeti
John McCormick
Add 'Arc' keyword to --proxy-skip-range for Azure Arc private-link en…
9495abe 
…dpoints (#61)

* Add 'Arc' keyword for --proxy-skip-range to expand Azure Arc private-link endpoints

* Add unit tests for Arc proxy-skip-range keyword expansion

* Add Arc keyword help text

* Bump Version

* Revert "Bump Version"

This reverts commit 6c4f3d0.
Drops the 1.10.13 -> 1.10.14 version bump from the PR; the Arc
proxy-skip-range feature can be published under a batched release
bump instead.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aa3f5a60-e3b1-49b4-a4e5-5d656000d376

* Text modify

* Extract Arc proxy-skip-range endpoints into a constant and simplify help text

Move the Arc private-link endpoint suffixes into a shared Arc_Private_Link_Endpoints constant and consume it from get_arc_proxy_skip_range_endpoints (behavior unchanged). Simplify the --proxy-skip-range help text and fold the Arc keyword into the existing examples, dropping the dedicated private-link example blocks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add proxy test for the Arc keyword in --proxy-skip-range

Assert that 'az connectedk8s update --proxy-skip-range Arc' expands to the Azure Arc private-link endpoints in the agent noProxy value.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Added dedup functionality and tests

---------

Co-authored-by: Sai Tareesh Reddy Eppeti <seppeti@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aa3f5a60-e3b1-49b4-a4e5-5d656000d376
jmccormick7 pushed a commit that referenced this pull request Aug 13, 2026
@Tareesh21 Sai Tareesh Reddy Eppeti
John McCormick
Add 'Arc' keyword to --proxy-skip-range for Azure Arc private-link en…
cb34699 
…dpoints (#61)

* Add 'Arc' keyword for --proxy-skip-range to expand Azure Arc private-link endpoints

* Add unit tests for Arc proxy-skip-range keyword expansion

* Add Arc keyword help text

* Bump Version

* Revert "Bump Version"

This reverts commit 6c4f3d0.
Drops the 1.10.13 -> 1.10.14 version bump from the PR; the Arc
proxy-skip-range feature can be published under a batched release
bump instead.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aa3f5a60-e3b1-49b4-a4e5-5d656000d376

* Text modify

* Extract Arc proxy-skip-range endpoints into a constant and simplify help text

Move the Arc private-link endpoint suffixes into a shared Arc_Private_Link_Endpoints constant and consume it from get_arc_proxy_skip_range_endpoints (behavior unchanged). Simplify the --proxy-skip-range help text and fold the Arc keyword into the existing examples, dropping the dedicated private-link example blocks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add proxy test for the Arc keyword in --proxy-skip-range

Assert that 'az connectedk8s update --proxy-skip-range Arc' expands to the Azure Arc private-link endpoints in the agent noProxy value.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Added dedup functionality and tests

---------

Co-authored-by: Sai Tareesh Reddy Eppeti <seppeti@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aa3f5a60-e3b1-49b4-a4e5-5d656000d376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianyunt jianyunt jianyunt approved these changes
@jmccormick7 jmccormick7 jmccormick7 approved these changes
@deeksha345 deeksha345 Awaiting requested review from deeksha345 deeksha345 is a code owner
@anagg929 anagg929 Awaiting requested review from anagg929 anagg929 is a code owner
@bgriddaluru bgriddaluru Awaiting requested review from bgriddaluru bgriddaluru is a code owner
+1 more reviewer
@9lash 9lash 9lash approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tareesh21 @jianyunt @9lash @jmccormick7