Skip to content

Continue onboarding after prediagnostic lifecycle warnings - #108

Open
ashnanze wants to merge 10 commits into
mainfrom
fix/connectedk8s-prediagnostic-lifecycle-warnings
Open

ashnanze wants to merge 10 commits into
mainfrom
fix/connectedk8s-prediagnostic-lifecycle-warnings

Conversation

@ashnanze

@ashnanze ashnanze commented Oct 16, 2026 •

Copy link
Copy Markdown

Summary

Restore the previous warn-and-continue behavior for prediagnostic job lifecycle conditions. The CLI logs an actionable warning that explicitly states onboarding will continue, emits telemetry, and continues unless a diagnostic check reports a failure.

This PR addresses rows 1–3 of Incident 887141382: az connectedk8s 1.11.2–1.11.4: review onboarding behavior changes from warn-and-continue to failure.

Behavior changes

Incident row Situation Regressed behavior (Current Behavior) Behavior restored by this PR
1 Diagnostic job could not be scheduled Returned Incomplete and stopped onboarding Log a warning, emit telemetry, and continue onboarding
2 Stale diagnostic Helm release could not be cleaned up Returned Incomplete and stopped onboarding Log a warning, emit telemetry, and continue onboarding
3 Diagnostic job was scheduled but did not finish Returned Incomplete and stopped onboarding Log a warning, emit telemetry, and continue when no check explicitly failed

Lifecycle warnings explicitly state that onboarding will continue without verified pre-onboarding diagnostic results.

Actual diagnostic failures remain blocking. If partial output contains a failed check, onboarding still stops with Failed.

Tests

Added coverage for:

  • Unscheduled diagnostic jobs
  • Diagnostic Helm cleanup failures
  • Incomplete jobs with empty output
  • Incomplete jobs with passing partial results
  • Incomplete jobs containing an explicit failed check
  • Lifecycle warning continuation messaging

@github-actions

Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions

Copy link
Copy Markdown

Hi @ashnanze

Release Suggestions

Module: connectedk8s

  • Please log updates into to src/connectedk8s/HISTORY.rst
  • Update VERSION to 2.0.0 in src/connectedk8s/setup.py

Notes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant