Skip to content

Update MicrosoftIdentityAbstractionsVersion to 12.6.1 - #4020

Merged
Gladwin Johnson VR (gladjohn) merged 2 commits into
masterfrom
gladjohn-MicrosoftIdentityAbstractionsVersion
Sep 1, 2026
Merged

Update MicrosoftIdentityAbstractionsVersion to 12.6.1#4020
Gladwin Johnson VR (gladjohn) merged 2 commits into
masterfrom
gladjohn-MicrosoftIdentityAbstractionsVersion

Conversation

@gladjohn

@gladjohn Gladwin Johnson VR (gladjohn) commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Update MicrosoftIdentityAbstractionsVersion to 12.6.1

@gladjohn
Gladwin Johnson VR (gladjohn) requested a review from a team as a code owner August 31, 2026 15:45
This was referenced Aug 31, 2026
Open
Merged
@iarekk

Iarek Kovtunenko (iarekk) commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The Build & Unit Tests failure here is expected from the 12.6.1 bump: 12.6.1
makes Clone() / the copy constructors allocate independent containers for the
mutable collections (ExtraParameters, ExtraQueryParameters,
ExtraHeadersParameters) instead of copying the references
(AzureAD/microsoft-identity-abstractions-for-dotnet#269). That inverts
SidecarOptionsIsolationTests.Clone_IsShallow_OnSharedMutableCollections, which
was written to document the previous shared-reference behavior.

Opened #4021 into this branch with the corrected test (rename to
Clone_IsolatesSharedMutableCollections, assert the collections are independent
after Clone()). It's test-only. Verified SidecarOptionsIsolationTests and the
core Microsoft.Identity.Web.Test unit tests pass against 12.6.1 locally. Merge
#4021 into this branch to clear the unit test run.

@gladjohn @bgavrilMS
Update MicrosoftIdentityAbstractionsVersion to 12.6.1
aa152c1
@iarekk @bgavrilMS
Update Clone isolation test for Abstractions 12.6.1 (#4021)
426e510 
Microsoft.Identity.Abstractions 12.6.1 changes Clone()/copy constructors to
allocate independent containers for the mutable collections (ExtraParameters,
ExtraQueryParameters, ExtraHeadersParameters). SidecarOptionsIsolationTests
.Clone_IsShallow_OnSharedMutableCollections asserted the previous shared-
reference behavior and now fails.

Rename it to Clone_IsolatesSharedMutableCollections and assert the collections
are independent after Clone() (NotSame, and a write to the clone does not appear
on the original). The sibling CloneForRequest test is unaffected.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d7561d5-2377-4311-b964-18a751a83302
@bgavrilMS
Bogdan Gavril (bgavrilMS) force-pushed the gladjohn-MicrosoftIdentityAbstractionsVersion branch from 3fb0425 to 426e510 Compare September 1, 2026 11:02
@gladjohn
Gladwin Johnson VR (gladjohn) merged commit 9799faa into master Sep 1, 2026
9 checks passed
@gladjohn
Gladwin Johnson VR (gladjohn) deleted the gladjohn-MicrosoftIdentityAbstractionsVersion branch September 1, 2026 15:25
@iarekk Iarek Kovtunenko (iarekk) mentioned this pull request Sep 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgavrilMS Bogdan Gavril (bgavrilMS) bgavrilMS approved these changes
@iarekk Iarek Kovtunenko (iarekk) iarekk approved these changes
@4gust Nilesh Choudhary (4gust) 4gust approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gladjohn @iarekk @bgavrilMS @4gust