Remove unnecessary flag switch that causes official build to break.#3700
Merged
Conversation
trwalke
approved these changes
Feb 3, 2026
trwalke
approved these changes
Feb 3, 2026
JoshLozensky
approved these changes
Feb 3, 2026
jmprieur
reviewed
Feb 3, 2026
jmprieur
left a comment
jmprieur
left a comment
Collaborator
There was a problem hiding this comment.
Let's up the version please 4.3.0 is out
and please follow the release process
| <!-- This needs to be greater than or equal to the validation baseline version. The conditional logic around TargetNetNext is there | ||
| to avoid NU5104 for packing a release version library with prerelease deps. By adding preview to it, that warning is avoided. | ||
| --> | ||
| <MicrosoftIdentityWebVersion Condition="'$(MicrosoftIdentityWebVersion)' == ''">4.3.1-preview</MicrosoftIdentityWebVersion> |
Collaborator
There was a problem hiding this comment.
It should be 4.3.1
IT should never have -preview1 in this file.
@copilot please update the agent.md to check that
| <ProjectGuid>{74737C0A-25E6-4E2C-B3AA-F7EECB7A07C7}</ProjectGuid> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <PackageReadmeFile>README.md</PackageReadmeFile> | ||
| <GeneratePackageOnBuild>True</GeneratePackageOnBuild> |
Collaborator
There was a problem hiding this comment.
What's the issue with this one?
This was referenced Mar 1, 2026
deps: Bump Microsoft.Identity.Web from 4.3.0 to 4.4.0
microsoft/dragon-copilot-extension-samples#173
Merged
Closed
Merged
Closed
This was referenced May 30, 2026
Open
This was referenced Jun 7, 2026
Merged
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seem unnecessary and causes overrides of binaries while signing.