Skip to content

Make Microsoft.Extensions.Http dependency framework friendly#3296

Merged
ksaaf merged 6 commits into
masterfrom
ksaaf/issue-3145
Mar 14, 2025
Merged

Make Microsoft.Extensions.Http dependency framework friendly#3296
ksaaf merged 6 commits into
masterfrom
ksaaf/issue-3145

Conversation

@ksaaf

@ksaaf ksaaf commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

Make Microsoft.Extensions.Http dependency framework friendly

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

This PR pins Microsoft.Extensions.Http ver 3.1.3 to .Net Framework/Standard and uses inbox version of Microsoft.Extensions.Http for .Net Core.

Description

  • Change involves updating Directory.Build.props and updating CSProj to reference Microsoft.Extensions.Http package only for non .Net Core.

Fixes #3145

@ksaaf ksaaf requested a review from a team as a code owner March 13, 2025 23:13

@jmprieur jmprieur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are static analysis issues to fix

Comment thread Directory.Build.props Outdated
Comment thread Directory.Build.props Outdated
@ksaaf ksaaf requested review from GeoK, jennyf19 and jmprieur March 14, 2025 23:03
@ksaaf ksaaf merged commit 1c57340 into master Mar 14, 2025
@ksaaf ksaaf deleted the ksaaf/issue-3145 branch March 14, 2025 23:50
sruke pushed a commit that referenced this pull request Mar 24, 2025
This PR pins Microsoft.Extensions.Http ver 3.1.3 to .Net Framework/Standard and uses inbox version of Microsoft.Extensions.Http for .Net Core.

Change involves updating Directory.Build.props and updating CSProj to reference Microsoft.Extensions.Http package only for non .Net Core.

---------

Co-authored-by: Kashif Mehmood <kashifm@ntdev.microsoft.com>
sruke added a commit that referenced this pull request Mar 24, 2025
* Send req_cnf for AtPop

* Configure AtPop with custom signed assertion

* Use WithAuthenticationExtension

* Adds AtPopOperationTests

* Make Microsoft.Extensions.Http dependency framework friendly (#3296)

This PR pins Microsoft.Extensions.Http ver 3.1.3 to .Net Framework/Standard and uses inbox version of Microsoft.Extensions.Http for .Net Core.

Change involves updating Directory.Build.props and updating CSProj to reference Microsoft.Extensions.Http package only for non .Net Core.

---------

Co-authored-by: Kashif Mehmood <kashifm@ntdev.microsoft.com>

* Update to IdentityModel 8.7.0 (#3307)

* 3.8.1 changelog (#3306)

* Update Directory.Build.props (#3305)

* Update src/Microsoft.Identity.Web.TokenAcquisition/AtPopOperation.cs

Co-authored-by: jennyf19 <jeferrie@microsoft.com>

---------

Co-authored-by: Sruthi Keerthi Rangavajhula (from Dev Box) <srangavajhul@microsoft.com>
Co-authored-by: Kashif Mehmood <33881304+ksaaf@users.noreply.github.com>
Co-authored-by: Kashif Mehmood <kashifm@ntdev.microsoft.com>
Co-authored-by: Peter <34331512+pmaytak@users.noreply.github.com>
Co-authored-by: Travis Walker <travis.walker@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.Http dependency is stuck with version 3.1.3

5 participants