Pass the assertion options to MSAL for ROPC call#3217
Merged
Conversation
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
bgavrilMS
reviewed
Jan 24, 2025
bgavrilMS
approved these changes
Jan 24, 2025
jmprieur
approved these changes
Jan 27, 2025
jmprieur
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Thanks @neha-bhargava
Collaborator
|
quite a bit of copied/pasted code. It would be time to have a based class for the CCA AcquireTokenX builders :) |
Contributor
Author
I was looking to see if I can reuse the code but not everything is valid in this case. I agree that the code can be refactored. Thanks for reviewing. |
This was referenced Jul 25, 2025
Closed
This was referenced Aug 1, 2025
This was referenced Jan 7, 2026
This was referenced Feb 16, 2026
This was referenced Apr 14, 2026
Merged
This was referenced Apr 27, 2026
Merged
This was referenced May 4, 2026
Merged
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3207
Summary of the changes (Less than 80 chars)
Pass the assertion/ merged options to MSAL for the ROPC flow and make sure if forceRefresh is set the silent flow is skipped
Description
Fixes #3207 (in this specific format)