build(deps): bump https://github.com/golangci/golangci-lint from v2.11.4 to 2.12.2 in the pre-commit group across 1 directory

[dependabot]

Bumps the pre-commit group with 1 update in the / directory: https://github.com/golangci/golangci-lint.

Updates https://github.com/golangci/golangci-lint from v2.11.4 to 2.12.2

Release notes

Sourced from https://github.com/golangci/golangci-lint's releases.

v2.12.2

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, the maintainers and linter authors.

We appreciate it! ❤️

For key updates, see the changelog.

Changelog

• 0b01827ae79a0cb92002b4b39867d133cef4c05c build(deps): bump github.com/onsi/ginkgo/v2 from 2.28.1 to 2.28.2 in /pkg/golinters/ginkgolinter/testdata in the linter-testdata group across 1 directory (#6559)
• 1a0697fc84d7f1376c8d8b1ebe20d9331c3d221f build(deps): bump github.com/pelletier/go-toml/v2 from 2.3.0 to 2.3.1 (#6548)
• f11cfe0f968601fb4cf40c704ca18e97b49282dd build(deps): bump github.com/ryancurrah/gomodguard/v2 from 2.1.0 to 2.1.3 (#6549)
• fb2c2411a7e6b05778c097c971e4017d2a6ef5c9 build(deps): bump github.com/shirou/gopsutil/v4 from 4.26.3 to 4.26.4 (#6547)
• 9a10710cd9d198dbda7ebdf39f7be4c659bc20c9 build(deps): bump github.com/uudashr/iface from 1.4.1 to 1.4.2 (#6557)
• 81e8f81bbb341152bb21dc516981cb4c30712088 gomodguard: fix blocked configuration (#6561)

Changelog

Sourced from https://github.com/golangci/golangci-lint's changelog.

Follow the news and releases on Mastodon and on Bluesky.

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, we appreciate it!

v1.64.8

Released on 2025-03-17

• Detects use of configuration files from golangci-lint v2

v1.64.7

Released on 2025-03-11

1. Linters bug fixes
   • depguard: from 2.2.0 to 2.2.1
   • dupl: from 3e9179ac440a to f665c8d69b32
   • gosec: from 2.22.1 to 2.22.2
   • staticcheck: from 0.6.0 to 0.6.1
2. Documentation
   • Add GitLab documentation

v1.64.6

Released on 2025-03-02

1. Linters bug fixes
   • asciicheck: from 0.4.0 to 0.4.1
   • contextcheck: from 1.1.5 to 1.1.6
   • errcheck: from 1.8.0 to 1.9.0
   • exptostd: from 0.4.1 to 0.4.2
   • ginkgolinter: from 0.19.0 to 0.19.1
   • go-exhaustruct: from 3.3.0 to 3.3.1
   • gocheckcompilerdirectives: from 1.2.1 to 1.3.0
   • godot: from 1.4.20 to 1.5.0
   • perfsprint: from 0.8.1 to 0.8.2
   • revive: from 1.6.1 to 1.7.0
   • tagalign: from 1.4.1 to 1.4.2

v1.64.5

Released on 2025-02-13

1. Bug fixes

... (truncated)

Commits

• c0d3ddc chore: prepare release
• 41f8dfb dev: keep only JSONSchema (#6564)
• 81e8f81 gomodguard: fix blocked configuration (#6561)
• 9a10710 build(deps): bump github.com/uudashr/iface from 1.4.1 to 1.4.2 (#6557)
• 0b01827 build(deps): bump github.com/onsi/ginkgo/v2 from 2.28.1 to 2.28.2 in /pkg/gol...
• 18bc4bf docs: update GitHub Action assets (#6554)
• 54a04eb dev: update Hugo (#6553)
• 0e8093b docs: update documentation assets (#6552)
• b665704 dev: workaround for post-release trigger (#6551)
• 006d012 dev: update documentation theme (#6550)
• Additional commits viewable in compare view

[jmclong]

@copilot can you update the pr to fix all of the new linter issues. Actually fix this issue (dont suppress)

[Copilot]

@copilot can you update the pr to fix all of the new linter issues. Actually fix this issue (dont suppress)

Fixed all 50 new goconst findings (plus a few more that surfaced as duplicates were consolidated) by extracting the duplicated string literals into named constants — no nolint suppressions. golangci-lint run now reports 0 issues. See b86fb17.

[jmclong]

@copilot if we made some change in some series of key - values pairs or in a structure to add a const but didn't add consts for other parts of that object, can we add those also as consts

[Copilot]

@copilot if we made some change in some series of key - values pairs or in a structure to add a const but didn't add consts for other parts of that object, can we add those also as con...

Good catch. Extended the consts to nearby siblings in the same maps/structs/test series:

• internal/csi/core/lvm/: added testFailoverModeKey / testFailoverAvail (siblings of testCapacityKey/testLimitKey in the same Parameters/VolumeContext maps).
• internal/manager/pvcleanup/: added pvcTestNode4 / pvcTestNode5 (siblings of pvcTestNode1..3 in the same Node.Name test series).
• internal/gc/: added gcTestNode3 (sibling of gcTestNode1/gcTestNode2).
• internal/pkg/probe/: added modelSamsungV2 / modelIntel (siblings of modelSamsung in the same model-list literals).

Lint is still clean and tests pass. See d7138f9.

[jmclong]

@copilot if there are consts like these that are present in the source, can you make them accessible by the test and use the const from teh source? Do a thorough scan

				"localdisk.csi.acstor.io/capacity":      "1073741824",
				"localdisk.csi.acstor.io/limit":         "0",
				"localdisk.csi.acstor.io/failover-mode": "availability",

[Copilot]

@copilot if there are consts like these that are present in the source, can you make them accessible by the test and use the const from teh source? Do a thorough scan

  			"localdisk.csi.acstor.io/...

Done. Scanned the test consts I added and replaced any that mirrored a production source const with a direct reference (so they can't drift):

• internal/csi/core/lvm/testconst_test.go: testCapacityKey → lvm.CapacityParam, testLimitKey → lvm.LimitParam, testFailoverModeKey → hyperconverged.FailoverModeParam, testFailoverAvail → hyperconverged.FailoverModeAvailability, testTopologyNodeKey → lvm.TopologyKey, testDeviceTypeDisk → probe.DeviceTypeDisk, testVolumeFullID → lvm.DefaultVolumeGroup + "#" + testVolume, testVgTagsLocalCsi → "vg_tags=" + lvm.DefaultVolumeGroupTag.
• internal/gc/testconst_test.go: gcTestSelectedInitialNode → csi.SelectedInitialNodeParam, gcTestSelectedNode → csi.SelectedNodeAnnotation, gcTestVolumeGroup → lvm.DefaultVolumeGroup, gcTestVolumeFullID derived from gcTestVolumeGroup.
• internal/csi/node/node_test.go: bare "localdisk.csi.acstor.io/capacity" literals (in PV attributes and recovery error message) → lvm.CapacityParam.

To make this work I converted lvm.CapacityParam and lvm.LimitParam from var → const (they were already initialized from a const expression DriverName + "/...", so the change is mechanical and they're now usable in const blocks).

Lint still 0 issues, affected unit tests pass. See f8cf9df.

[jmclong]

@dependabot recreate

[dependabot]

Looks like https://github.com/golangci/golangci-lint is updatable in another way, so this is no longer needed.