Generating Config Files using CLI tool - #879
Merged
Shyam Sundar J (severussundar) merged 96 commits intoOct 27, 2022
Merged
Conversation
…ay names to pipeline tasks
Aniruddh Munde (Aniruddh25)
requested changes
Oct 15, 2022
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
Good starter, but looking for the actual scripts - so that it represents the customer scenario.
Shyam Sundar J (severussundar)
requested a review
from Aniruddh Munde (Aniruddh25)
October 25, 2022 16:09
Aniruddh Munde (Aniruddh25)
approved these changes
Oct 25, 2022
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for accommodating the changes to be able to generate the config files manually too.
Shyam Sundar J (severussundar)
deleted the
dev/shyamsundarj/generating-config-files-using-scripts
branch
October 27, 2022 05:29
1 task
Aniruddh Munde (Aniruddh25)
pushed a commit
that referenced
this pull request
Oct 31, 2022
## Why make this change? - Closes #878 - As we removed all the temp config files from our repo, and going forward we would be using cli to generate it. (ref: #879). This document will help users to generate views/stored-procedure using cli. ## What is this change? - New doc file created under docs/internals. - updated doc with new command line options. - Added examples and sample commands along with the generated json objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
Text file for each database type containing the dab commands is added in the folder
ConfigGeneratorsScripts (bash and powershell) are added that reads the command files and executes them using the DAB dll executable
A property
generateConfigFilescan be specified along with the build command to generate the config files along with the build. Exact build command :dotnet build -p:generateConfigFiles=trueRunning just
dotnet buildwill build the entire project but skip generating the config files.This gives users the flexibility to generate the config files along with build if they wish to do so.
Reference config files for Sql(
dab-config.SqlReferenceConfig.json) and Cosmos(dab-config.CosmosReferenceConfig.json) are added.The
sourcetype has been modified in the schema to supporttables, views and stored-proceduresin the config.For local development,
How was this tested?
Side effects of this change