Skip to content

Parallel CRUD operations - SQL DBs - #801

Merged
Shyam Sundar J (severussundar) merged 26 commits into
mainfrom
dev/shyamsundarj/concurrent-test-2
Sep 27, 2022
Merged

Parallel CRUD operations - SQL DBs#801
Shyam Sundar J (severussundar) merged 26 commits into
mainfrom
dev/shyamsundarj/concurrent-test-2

Conversation

@severussundar

@severussundar Shyam Sundar J (severussundar) commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What is this change?

  • One of the PRs for the issue #708
    • Adds test that performs parallel CRUD operations (both REST and GraphQL) in parallel for SQL databases.
    • Adds tests that perform parallel CRUD operations on the same item for SQL databases.
    • Approach Document
    • At the moment, these tests are not integrated into the pipeline. The integration will be done as part of a subsequent PR.

How was this tested?

  • Scripts were tested by running locally

Tests on same item

@severussundar Shyam Sundar J (severussundar) added the testing Test related issue. label Sep 19, 2022
This was linked to issues Sep 19, 2022
Tests with concurrent REST and GraphQL API requests #708
Closed
Concurrent delete requests (acting on same item) could report misleading GraphQL results #790
Closed
@severussundar Shyam Sundar J (severussundar) removed a link to an issue Sep 19, 2022
Concurrent delete requests (acting on same item) could report misleading GraphQL results #790
Closed
jarupatj
Jarupat Jisarojito (jarupatj) suggested changes Sep 20, 2022
View reviewed changes
Comment thread src/Service.Tests/ConcurrentTests/SqlTests/ParallelCrudOperationsTestCase.js Outdated
Comment thread src/Service.Tests/ConcurrentTests/SqlTests/ParallelReadsTestCase.js Outdated
Comment thread src/Service.Tests/ConcurrentTests/SqlTests/ParallelCrudOperationsTestCase.js Outdated
Aniruddh25
Aniruddh Munde (Aniruddh25) reviewed Sep 20, 2022
View reviewed changes
Comment thread src/Service.Tests/ConcurrentTests/SqlTests/test.js Outdated
Aniruddh25
Aniruddh Munde (Aniruddh25) requested changes Sep 20, 2022
View reviewed changes

@Aniruddh25 Aniruddh Munde (Aniruddh25) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for inclusion of tests on same item

Aniruddh25
Aniruddh Munde (Aniruddh25) reviewed Sep 24, 2022
View reviewed changes
Comment thread src/Service.Tests/ConcurrentTests/Helper.js Outdated
Aniruddh25
Aniruddh Munde (Aniruddh25) reviewed Sep 24, 2022
View reviewed changes
Comment thread src/Service.Tests/ConcurrentTests/Helper.js Outdated
Aniruddh25
Aniruddh Munde (Aniruddh25) reviewed Sep 24, 2022
View reviewed changes
Comment thread src/Service.Tests/ConcurrentTests/SqlTests/test.js
Aniruddh25
Aniruddh Munde (Aniruddh25) reviewed Sep 26, 2022
View reviewed changes
Comment thread src/Service.Tests/ConcurrentTests/SqlTests/ParallelDeleteOnSameItem.js Outdated
Aniruddh25
Aniruddh Munde (Aniruddh25) requested changes Sep 26, 2022
View reviewed changes

@Aniruddh25 Aniruddh Munde (Aniruddh25) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a PATCH and PUT REST test case

Aniruddh25
Aniruddh Munde (Aniruddh25) reviewed Sep 26, 2022
View reviewed changes
Comment thread src/Service.Tests/ConcurrentTests/Helper.js Outdated
Aniruddh25
Aniruddh Munde (Aniruddh25) reviewed Sep 27, 2022
View reviewed changes
Comment thread src/Service.Tests/ConcurrentTests/SqlTests/ParallelCreateOperations.js Outdated
Aniruddh25
Aniruddh Munde (Aniruddh25) approved these changes Sep 27, 2022
View reviewed changes

@Aniruddh25 Aniruddh Munde (Aniruddh25) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after modifying Create to be on SAME id.

@severussundar
Shyam Sundar J (severussundar) deleted the dev/shyamsundarj/concurrent-test-2 branch September 27, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aniruddh25 Aniruddh Munde (Aniruddh25) Aniruddh25 approved these changes
@mbhaskar Bhaskar Mallapragada (mbhaskar) Awaiting requested review from mbhaskar
@JelteF Jelte Fennema-Nio (JelteF) Awaiting requested review from JelteF
@seantleonard Sean Leonard (seantleonard) Awaiting requested review from seantleonard
@Mathos1432 Mathieu Tremblay (Mathos1432) Awaiting requested review from Mathos1432
@gledis69 Gledis Zeneli (gledis69) Awaiting requested review from gledis69
@aaronburtle aaronburtle Awaiting requested review from aaronburtle aaronburtle is a code owner
@milismsft Milis (milismsft) Awaiting requested review from milismsft
@junsu0ms Jun Su (junsu0ms) Awaiting requested review from junsu0ms
@tarazou9 tarazou9 Awaiting requested review from tarazou9
@ayush3797 Ayush Agarwal (ayush3797) Awaiting requested review from ayush3797
@abhishekkumams Abhishek Kumar (abhishekkumams) Awaiting requested review from abhishekkumams
@aaronpowell Aaron Powell (aaronpowell) Awaiting requested review from aaronpowell
+1 more reviewer
@jarupatj Jarupat Jisarojito (jarupatj) jarupatj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@severussundar Shyam Sundar J (severussundar)

Labels

testing Test related issue.

Projects

Data API builder
Status: Done

Milestone

Sept2022

Development

Successfully merging this pull request may close these issues.

Tests with concurrent REST and GraphQL API requests

3 participants

@severussundar @jarupatj @Aniruddh25