Throw exception when primary key could not be determined - #414
Merged
Conversation
Ayush Agarwal (ayush3797)
requested review from
Aniruddh Munde (Aniruddh25),
Jelte Fennema-Nio (JelteF),
Mathieu Tremblay (Mathos1432),
aaronburtle,
Aaron Powell (aaronpowell),
Abhishek Kumar (abhishekkumams),
Gledis Zeneli (gledis69),
Jarupat Jisarojito (jarupatj),
Jun Su (junsu0ms),
Bhaskar Mallapragada (mbhaskar),
Milis (milismsft),
Sean Leonard (seantleonard),
swviswan and
tarazou9
as code owners
May 14, 2022 09:42
Aniruddh Munde (Aniruddh25)
requested changes
May 15, 2022
Aniruddh Munde (Aniruddh25)
left a comment
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
Need a different status code
…code for init failure
Aniruddh Munde (Aniruddh25)
approved these changes
May 15, 2022
Aniruddh Munde (Aniruddh25)
left a comment
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Please make sure to add -ve tests in a future PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is the change needed?
Sometimes, view definition can be quite complicated and ADO.NET db data adapter may not be able to determine PK of a view. In such cases, we need to fail initialization and throw an exception.
How was this done?
Throw an exception when the primaryKeys list for a view is empty.