Patch #379 since the config was not valid - #391
Merged
Conversation
Gledis Zeneli (gledis69)
requested review from
Aniruddh Munde (Aniruddh25),
Jelte Fennema-Nio (JelteF),
Mathieu Tremblay (Mathos1432),
aaronburtle,
Jarupat Jisarojito (jarupatj),
Jun Su (junsu0ms),
Bhaskar Mallapragada (mbhaskar),
Milis (milismsft),
Sean Leonard (seantleonard),
Naveen Singh (simplynaveen20) and
swviswan
as code owners
May 6, 2022 19:16
Aniruddh Munde (Aniruddh25)
approved these changes
May 6, 2022
Aniruddh Munde (Aniruddh25)
left a comment
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for the test
Aaron Powell (aaronpowell)
pushed a commit
that referenced
this pull request
May 10, 2022
This was my mistake. I did not rerun the application after I did the merge with main, I only ran the tests. If I had run the application, I would have seen that the config was not valid and the run is unsuccessful. This PR fixes the config, but also adds a test to check if the config is valid or not so this scenario does not repeat again. The issue was that due to change in GraphQLBuilder.FormatNameForObject function I switched to GraphQLBuilder.FormatNameForField which does not capitalize the first letters of the name. That was causing the config validator to fail. I decided to remove this completely since the gql type capitalization (whatever was decided by the schema generation or the user directly) should be appropriate to use to name [TypeName]FilterInput and [TypeName]OrderByInput input types without any extra formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was my mistake.
I did not rerun the application after I did the merge with main, I only ran the tests.
If I had run the application, I would have seen that the config was not valid and the run is unsuccessful.
This PR fixes the config, but also adds a test to check if the config is valid or not so this scenario does not repeat again.
The issue was that due to change in
GraphQLBuilder.FormatNameForObjectfunction I switched toGraphQLBuilder.FormatNameForFieldwhich does not capitalize the first letters of the name. That was causing the config validator to fail.I decided to remove this completely since the gql type capitalization (whatever was decided by the schema generation or the user directly) should be appropriate to use to name
[TypeName]FilterInputand[TypeName]OrderByInputinput types without any extra formatting.