Upgrade SQL version for Pipelines by RubenCerna2079 · Pull Request #3697 · Azure/data-api-builder

RubenCerna2079 · 2026-07-06T21:08:08Z

Why make this change?

Solves issue Upgrade SQL version used in pipeline tests #3696

What is this change?

Changed the SqlLocalDB.msi to use the new SQL 2025 version, and updated all the places where we set the SQL version to use SQL 2025.

How was this tested?

Using vector data type in follow up PR. If the SQL version is anything less than 2025, the pipeline would fail.
#3677

Sample Request(s)

N/A

Copilot

Pull request overview

This PR updates the SQL Server versions used by CI pipelines and test schema initialization so that MsSql/DwSql integration tests can run against SQL Server 2025 features (notably the vector data type), addressing issue #3696.

Changes:

Added a vector_type_table (including a max-dimension vector(1998) case) to the MsSql test schema so schema initialization fails on older SQL versions.
Updated pipeline LocalDB installer URL and version code to SQL 2025 equivalents.
Updated the Linux SQL Server container image tag used in pipeline setup to SQL Server 2025.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Service.Tests/DatabaseSchema-MsSql.sql	Adds a new `vector_type_table` and seed data to require SQL Server 2025 vector support during schema init.
src/Service.Tests/dab-config.MsSql.json	Minor formatting/EOF change only (no functional config updates).
scripts/start-mssql-server.bash	Updates the SQL Server Linux container image tag to 2025.
.pipelines/mssql-pipelines.yml	Updates LocalDB installer URL and SQL version code for MsSql pipeline jobs.
.pipelines/dwsql-pipelines.yml	Updates LocalDB installer URL and SQL version code for DwSql pipeline jobs.

souvikghosh04

we should not club any other changes apart from the minimal SQL 2025 upgrade related change. PR description should also reflect the same.

souvikghosh04

thanks for addressing the comments. approved

RubenCerna2079 · 2026-07-13T15:42:13Z

/azp run

azure-pipelines · 2026-07-13T15:42:59Z

Azure Pipelines successfully started running 6 pipeline(s).

## What this PR does Adds the database test fixture and REST integration tests for SQL Server 2025 `JSON` columns. It builds on Phase 2 (which taught the engine to treat `JSON` as a normal `string`) and proves the behavior end-to-end through the REST API. This follows the exact pattern of the recently merged **vector data type** feature (#3677), and is unblocked by CI now running SQL Server 2025 (#3697). ## What's included - **Test table** — a `profiles` table with an `id` and a `metadata json` column, plus 5 seed rows covering a simple object, an array, a deeply nested object, unicode + emoji, and `NULL`. - **Entity** — a `Profile` entity (REST + GraphQL enabled) in the MsSql test config and config generator. - **REST tests** — `MsSqlRestJsonTypesTests`: read (list, by id, null, array, nested, unicode), insert, update (PUT/PATCH), clear-to-null, and delete. Because DAB treats `JSON` as a string, the tests parse `metadata` and compare it **semantically**, so they're robust to any whitespace / key-order normalization the engine applies. ## No gating needed Unlike the earlier plan, the table is created **unconditionally** (no server-version guard) — CI runs SQL Server 2025 and the schema already uses the 2025-only `vector` type the same way. ## Delivery plan | Phase | What | Status | |------|------|--------| | 1 | .NET 10 + SqlClient 6.x (prerequisite) | ✅ Merged (#3697/#3656) | | 2 | JSON type + error mapping (engine) | ✅ Merged (#3691) | | **3** | **Test fixture + REST CRUD tests (this PR)** | 🚧 In review | | 3b | GraphQL / OpenAPI / MCP schema-discovery tests | Next | | 4 | Error/filter edge cases + regression | After | ## Notes - Requires SQL Server 2025 / Azure SQL (native `json` type). - No changes to PostgreSQL, MySQL, DwSql, or CosmosDB. - Related issue: #2768. --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@aaronburtle

…QL tests (#3738) ## Why Part of MSSQL native `JSON` support (#2768). Started as Phase 3b **schema-discovery tests**, but review (thanks @aaronburtle) surfaced a real product inconsistency that this PR now also fixes. **The problem:** #2768 requires a `JSON` column to be treated as a normal `string` for **input and output**. But the MSSQL read path (`FOR JSON PATH`) was *inlining* a native `json` column as a nested JSON **object**. Consequences: - REST returned `"metadata": {"role":"admin"}` (object) instead of `"metadata": "{\"role\":\"admin\"}"` (string). - A GraphQL read of the `String`-typed field threw a `GraphQLMapping` error — the `String` leaf resolver calls `JsonElement.GetString()`, which fails on an object. So schema introspection could pass while `profile_by_pk(id:1){ metadata }` failed at runtime. - OpenAPI/GraphQL advertised `string`, contradicting the object runtime — generated clients would mis-model the field. ## What **Engine fix** (`MsSqlQueryBuilder`): the read path now casts a native `json` column (`SqlDbType.Json`) to `NVARCHAR(MAX)` in `WrappedColumns`, so `FOR JSON PATH` emits it as an escaped JSON **string** rather than inlining it as an object. This is the single choke point for REST **and** GraphQL reads. Regular `nvarchar` columns are untouched. Mutations already return `json` as a string via the tabular `OUTPUT` clause, so no change was needed there. **Tests:** | Layer | Test | Asserts | |------|------|---------| | OpenAPI | `JsonTypeSchemaTests` | `metadata` is `type: string` with no `format` in the **response** and both **request-body** schemas (`Profile_NoAutoPK` for POST, `Profile_NoPK` for PUT/PATCH) | | GraphQL introspection | `MsSqlGraphQLJsonSchemaTests` | `Profile.metadata` is the built-in `String` scalar (no custom JSON scalar) | | GraphQL read (new) | `MsSqlGraphQLJsonSchemaTests` | `profile_by_pk(id:1){ metadata }` returns the payload as a JSON **string** — guards against introspection passing while a real read throws | | REST | `MsSqlRestJsonTypesTests` (updated) | flipped back to the string contract: `metadata` is returned as a JSON **string** (`ParseMetadata`/`GetJsonTypeList` assert `JsonValueKind.String`) | > Note: DAB's OpenAPI documentor does not emit `Nullable` on the property schema for **any** column type, so the schema tests assert `type: string` + no `format` (not nullability). ## Intentionally omitted - **MCP `describe_entities` (T010)**: it projects only the config field `name`/`description`, not DB column data types, so there is no JSON-specific behavior to assert. ## Notes - **This PR now includes a product (engine) change**, not tests only. - Requires SQL Server 2025 / Azure SQL (native `json`); CI already runs SQL 2025. - Cannot be run locally (no SQL 2025 here) — relying on CI. ## Delivery plan | Phase | What | Status | |-------|------|--------| | 1 | .NET 10 + SqlClient 6.x | ✅ Merged (#3697/#3656) | | 2 | JSON type + error mapping (engine) | ✅ Merged (#3691) | | 3 | Test fixture + REST CRUD tests | ✅ Merged (#3720) | | **3b** | **json-as-string read fix + OpenAPI/GraphQL discovery & read tests (this PR)** | 🚧 | | 4 | Error/filter edge cases + regression + polish | Next |

RubenCerna2079 added 3 commits July 6, 2026 14:07

Add new SQL version

6d7badc

Add vector table to schema

e562894

Remove vector table to schema

468b957

RubenCerna2079 changed the title ~~Add new SQL version~~ Upgrade SQL version for Pipelines Jul 6, 2026

RubenCerna2079 added 2 commits July 6, 2026 15:24

Update version to 2025

ab478c0

Remove commands

65ddcc9

RubenCerna2079 marked this pull request as ready for review July 7, 2026 17:34

Copilot AI review requested due to automatic review settings July 7, 2026 17:34

RubenCerna2079 requested review from Alekhya-Polavarapu, Aniruddh25, JerryNixon, aaronburtle, anushakolan, rusamant, sourabh1007, souvikghosh04, stuartpa and vadeveka as code owners July 7, 2026 17:34

RubenCerna2079 added 2.1 assign-for-review labels Jul 7, 2026

RubenCerna2079 added this to Data API builder Jul 7, 2026

github-project-automation Bot moved this to Todo in Data API builder Jul 7, 2026

RubenCerna2079 added this to the July 2026 milestone Jul 7, 2026

Copilot started reviewing on behalf of RubenCerna2079 July 7, 2026 17:34 View session

RubenCerna2079 linked an issue Jul 7, 2026 that may be closed by this pull request

Upgrade SQL version used in pipeline tests #3696

Closed

github-actions Bot assigned aaronburtle and Aniruddh25 Jul 7, 2026

github-actions Bot removed the assign-for-review label Jul 7, 2026

RubenCerna2079 assigned souvikghosh04 and unassigned aaronburtle Jul 7, 2026

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread .pipelines/mssql-pipelines.yml

Comment thread .pipelines/mssql-pipelines.yml

Comment thread scripts/start-mssql-server.bash

Comment thread .pipelines/dwsql-pipelines.yml

RubenCerna2079 mentioned this pull request Jul 7, 2026

[Phase 2] Enable MSSQL JSON data type - type mapping & error codes (engine) #3691

Merged

Aniruddh25 approved these changes Jul 8, 2026

View reviewed changes

souvikghosh04 requested changes Jul 9, 2026

View reviewed changes

Comment thread src/Service.Tests/DatabaseSchema-MsSql.sql Outdated

Comment thread src/Service.Tests/DatabaseSchema-MsSql.sql Outdated

Comment thread src/Service.Tests/DatabaseSchema-MsSql.sql Outdated

github-project-automation Bot moved this from Todo to Review In Progress in Data API builder Jul 9, 2026

Remove vector data type table

a278c6d

Aniruddh25 approved these changes Jul 9, 2026

View reviewed changes

Aniruddh25 enabled auto-merge (squash) July 9, 2026 19:07

souvikghosh04 approved these changes Jul 13, 2026

View reviewed changes

Merge branch 'main' into dev/rubencerna/update-sql-pipeline-version

07395d7

RubenCerna2079 disabled auto-merge July 13, 2026 17:37

RubenCerna2079 enabled auto-merge (squash) July 13, 2026 17:37

RubenCerna2079 merged commit 4e6bd71 into main Jul 13, 2026
12 checks passed

RubenCerna2079 deleted the dev/rubencerna/update-sql-pipeline-version branch July 13, 2026 17:38

github-project-automation Bot moved this from Review In Progress to Done in Data API builder Jul 13, 2026

souvikghosh04 mentioned this pull request Jul 14, 2026

[Phase 3] MSSQL JSON - test fixture + REST CRUD tests #3720

Merged

This was referenced Jul 28, 2026

[Phase 3b] MSSQL JSON - return json as string on read + OpenAPI/GraphQL tests #3738

Merged

[Phase 3b] MSSQL JSON - OpenAPI + GraphQL schema-discovery tests #3739

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade SQL version for Pipelines - #3697

Upgrade SQL version for Pipelines#3697
RubenCerna2079 merged 7 commits into
mainfrom
dev/rubencerna/update-sql-pipeline-version

RubenCerna2079 commented Jul 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

souvikghosh04 left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

souvikghosh04 left a comment

Uh oh!

RubenCerna2079 commented Jul 13, 2026

Uh oh!

azure-pipelines Bot commented Jul 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

RubenCerna2079 commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why make this change?

What is this change?

How was this tested?

Sample Request(s)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

souvikghosh04 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

souvikghosh04 left a comment

Choose a reason for hiding this comment

Uh oh!

RubenCerna2079 commented Jul 13, 2026

Uh oh!

azure-pipelines Bot commented Jul 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RubenCerna2079 commented Jul 6, 2026 •

edited

Loading

souvikghosh04 left a comment •

edited

Loading