Skip to content

Added automation for Doc.MS release step#965

Merged
sima-zhu merged 2 commits into
Azure:masterfrom
sima-zhu:addLabels
Sep 11, 2020
Merged

Added automation for Doc.MS release step#965
sima-zhu merged 2 commits into
Azure:masterfrom
sima-zhu:addLabels

Conversation

@sima-zhu

@sima-zhu sima-zhu commented Sep 4, 2020

Copy link
Copy Markdown
Contributor

This is an ask from Doc.MS release step. We want to create pull request with automation label.

Issue: Azure/azure-sdk#1635

Added the auto-merge label for testing.
PR: MicrosoftDocs/azure-docs-sdk-node#843

TargetDocRepoOwner: ''
PRBranchName: 'smoke-test-rdme'
SourceBranchName: 'smoke-test'
PRLabels: 'automation'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scbedd should we go ahead and also start applying the 'auto-merge' label?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync with @scbedd , the DocMs PR does not have any auto-merge label created yet. Will have auto-merge as a placeholder for now, but it might not function like it should be. Meanwhile, I will have a simple test to verify the script did not fail if the label does not exist.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After chatting with @scbedd I think we want to just replace 'automation' with 'auto-merge'.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, forgot to update. Thanks!

@weshaggard

Copy link
Copy Markdown
Member

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny

Copy link
Copy Markdown
Contributor

Could we please get some descriptions on the PRs so that it makes it more obvious what we are reviewing (quick summary of what is being added/changed/removed ... at a conceptual level and why).

@sima-zhu
sima-zhu requested a review from weshaggard September 9, 2020 23:09

@scbedd scbedd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hold for releases!

@sima-zhu
sima-zhu merged commit 72f1cf0 into Azure:master Sep 11, 2020
@sima-zhu
sima-zhu deleted the addLabels branch September 11, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants