Skip to content

Tool guidance#2384

Merged
sima-zhu merged 16 commits into
Azure:mainfrom
sima-zhu:tool_guidance
Dec 7, 2021
Merged

Tool guidance#2384
sima-zhu merged 16 commits into
Azure:mainfrom
sima-zhu:tool_guidance

Conversation

@sima-zhu

@sima-zhu sima-zhu commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@check-enforcer-staging

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

Comment thread tools/CONTRIBUTING.md Outdated
Comment thread tools/CONTRIBUTING.md Outdated
Comment thread tools/CONTRIBUTING.md Outdated
Comment thread tools/CONTRIBUTING.md Outdated
Comment thread tools/CONTRIBUTING.md Outdated
Comment thread tools/CONTRIBUTING.md Outdated
Comment thread tools/CONTRIBUTING.md Outdated
sima-zhu and others added 6 commits December 6, 2021 11:00
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
@sima-zhu sima-zhu requested review from benbp and weshaggard December 6, 2021 21:28
Comment thread tools/CONTRIBUTING.md Outdated
Comment thread tools/CONTRIBUTING.md
@@ -0,0 +1,45 @@
# Azure SDK Tools Contribution Guidelines

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put this in the root of the repo.

@weshaggard weshaggard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good starting point and we can start referring folks to it and update it as more questions arise.

@sima-zhu sima-zhu marked this pull request as ready for review December 7, 2021 01:15
@sima-zhu sima-zhu requested a review from a team as a code owner December 7, 2021 01:15
@sima-zhu

sima-zhu commented Dec 7, 2021

Copy link
Copy Markdown
Contributor Author

/check-enforcer override

@sima-zhu sima-zhu merged commit 7739345 into Azure:main Dec 7, 2021
@sima-zhu sima-zhu deleted the tool_guidance branch December 7, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants