Downgrade to netcoreapp3.1

[JoshLove-msft]

This change would make it easier for the .NET repo to use a build time dependency on the Test Proxy.

Also, netcoreapp3.1 is an LTS version whereas .NET 5.0 is not.

[pakrym]

Do we need to update the docker file or some other infrastructure?

[JoshLove-msft]

Do we need to update the docker file or some other infrastructure?

Good point - I think we would at least need to update:

• https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/docker/dockerfile
• https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/docker/dockerfile-win

though I'm not clear on how to actually test that the change is working.

[JoshLove-msft]

Do we need to update the docker file or some other infrastructure?

Good point - I think we would at least need to update:

• https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/docker/dockerfile
• https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/docker/dockerfile-win

though I'm not clear on how to actually test that the change is working.

@scbedd will be checking on this.

[check-enforcer-staging]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

[scbedd]

I'll definitely help make changes on docker, but I'm seeing the following locally.

1. We need to update ci.yml to target 3.1
2. Update the targeted base docker image versions
3. Update the paths that copy dotnet-devcert out of the SDK -> runtime docker builds.

I'll help with any, but I don't have write permissions to the branch.

[JoshLove-msft]

Ci

I'll definitely help make changes on docker, but I'm seeing the following locally.

1. We need to update ci.yml to target 3.1
2. Update the targeted base docker image versions
3. Update the paths that copy dotnet-devcert out of the SDK -> runtime docker builds.

I'll help with any, but I don't have write permissions to the branch.

CI is now passing. I think we still need to do 2 and 3.

[scbedd]

❤️ that's an awesome workaround. Didn't know this would work :)

[scbedd]

Just a heads up I'm actively working on these docker issues. Hoping I'll have a fix sometime tomorrow.

[scbedd]

@JoshLove-msft confirmed working. It's not the best solution, as it does expand our docker images somewhat, but I need to unblock you and powershell trusting isn't a silver bullet either.

We'd need to do a linux version of the importing that dotnet dev certs is doing on linux, and given that the powershell one isn't even working properly for me on windows, I don't want to delay your PR by some "I don't know until it's solved" measure.

[JoshLove-msft]

@JoshLove-msft confirmed working. It's not the best solution, as it does expand our docker images somewhat, but I need to unblock you and powershell trusting isn't a silver bullet either.

We'd need to do a linux version of the importing that dotnet dev certs is doing on linux, and given that the powershell one isn't even working properly for me on windows, I don't want to delay your PR by some "I don't know until it's solved" measure.

For now we still have the dependency on 5.0 in the .NET repo, so I don't think it is urgent that we merge this.

[pakrym]

For now we still have the dependency on 5.0 in the .NET repo, so I don't think it is urgent that we merge this.

The test-proxy is the last thing that requires it.

[JoshLove-msft]

For now we still have the dependency on 5.0 in the .NET repo, so I don't think it is urgent that we merge this.

The test-proxy is the last thing that requires it.

Yes, but if this would break dev certs for linux, I don't think we should merge it yet.

[JoshLove-msft]

For now we still have the dependency on 5.0 in the .NET repo, so I don't think it is urgent that we merge this.

The test-proxy is the last thing that requires it.

Yes, but if this would break dev certs for linux, I don't think we should merge it yet.

Or is everything currently working right now with the latest changes @scbedd?

[scbedd]

@JoshLove-msft it's not an optimal solution but it's definitely working 100%. Confirmed by hitting up https://localhost:5001/Info/Available on my local box on both versions. We should be good with this merge.

[JoshLove-msft]

/check-enforcer reset

[scbedd]

/azp run tools - test-proxy - ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[scbedd]

/check-enforcer override