Migration waza skills to vally#15376
Merged
Merged
Conversation
f003161 to
e89ebe4
Compare
e89ebe4 to
bf9ace7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the repo’s Copilot skill evaluation setup from the deprecated azd/waza format to the @microsoft/vally-cli framework, including updated CI/ADO automation and converted eval specs.
Changes:
- Introduces Vally project configuration (
.github/skills/.vally.yaml) and converts per-skill eval specs to Vally stimuli/graders (plus newtrigger.eval.yamlfiles). - Simplifies the GitHub Actions workflow to Vally lint only, and adds an Azure DevOps pipeline to run evaluations.
- Removes legacy waza artifacts (
.waza.yaml, task-based eval YAMLs, and old trigger test YAMLs) and flattenscompatibilityfrontmatter in SKILL files.
Reviewed changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/skill-eval.yml | Adds Azure DevOps pipeline to run Vally evals and publish results. |
| .github/workflows/skill-eval.yml | Switches CI to Vally lint-only workflow. |
| .github/skills/skill-authoring/tasks/authoring-basic-001.yaml | Removes legacy waza task definition. |
| .github/skills/skill-authoring/evals/trigger_tests.yaml | Removes legacy trigger test list. |
| .github/skills/skill-authoring/evals/trigger.eval.yaml | Adds Vally trigger/anti-trigger eval spec. |
| .github/skills/skill-authoring/evals/tasks/basic-trigger.yaml | Removes legacy waza task. |
| .github/skills/skill-authoring/evals/tasks/anti-trigger.yaml | Removes legacy waza task. |
| .github/skills/skill-authoring/evals/eval.yaml | Converts main eval spec to Vally stimuli/graders. |
| .github/skills/skill-authoring/eval.yaml | Removes legacy root eval config. |
| .github/skills/skill-authoring/SKILL.md | Flattens compatibility frontmatter and adjusts wording. |
| .github/skills/sensei/tasks/sensei-basic-001.yaml | Removes legacy waza task definition. |
| .github/skills/sensei/evals/trigger_tests.yaml | Removes legacy trigger test list. |
| .github/skills/sensei/evals/trigger.eval.yaml | Adds Vally trigger/anti-trigger eval spec. |
| .github/skills/sensei/evals/tasks/basic-trigger.yaml | Removes legacy waza task. |
| .github/skills/sensei/evals/tasks/anti-trigger.yaml | Removes legacy waza task. |
| .github/skills/sensei/evals/eval.yaml | Converts main eval spec to Vally stimuli/graders. |
| .github/skills/sensei/eval.yaml | Removes legacy root eval config. |
| .github/skills/sensei/SKILL.md | Removes/updates related skills section (per ref lint needs). |
| .github/skills/markdown-token-optimizer/tasks/optimize-basic-001.yaml | Removes legacy waza task definition. |
| .github/skills/markdown-token-optimizer/evals/trigger_tests.yaml | Removes legacy trigger test list. |
| .github/skills/markdown-token-optimizer/evals/trigger.eval.yaml | Adds Vally trigger/anti-trigger eval spec. |
| .github/skills/markdown-token-optimizer/evals/tasks/basic-trigger.yaml | Removes legacy waza task. |
| .github/skills/markdown-token-optimizer/evals/tasks/anti-trigger.yaml | Removes legacy waza task. |
| .github/skills/markdown-token-optimizer/evals/eval.yaml | Converts main eval spec to Vally stimuli/graders. |
| .github/skills/markdown-token-optimizer/eval.yaml | Removes legacy root eval config. |
| .github/skills/markdown-token-optimizer/SKILL.md | Flattens compatibility frontmatter. |
| .github/skills/azure-typespec-author/SKILL.md | Flattens compatibility frontmatter. |
| .github/skills/azsdk-common-sdk-release/tasks/release-trigger-001.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-sdk-release/tasks/release-readiness-001.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-sdk-release/tasks/release-negative-001.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-sdk-release/tasks/release-basic-001.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-sdk-release/evals/trigger_tests.yaml | Removes legacy trigger test list. |
| .github/skills/azsdk-common-sdk-release/evals/trigger.eval.yaml | Adds Vally trigger/anti-trigger eval spec. |
| .github/skills/azsdk-common-sdk-release/evals/tasks/basic-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-sdk-release/evals/tasks/anti-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-sdk-release/evals/eval.yaml | Converts main eval spec to Vally stimuli/graders. |
| .github/skills/azsdk-common-sdk-release/eval.yaml | Removes legacy root eval config. |
| .github/skills/azsdk-common-sdk-release/SKILL.md | Flattens compatibility frontmatter. |
| .github/skills/azsdk-common-prepare-release-plan/tasks/should-not-trigger.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-prepare-release-plan/tasks/link-sdk-prs.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-prepare-release-plan/tasks/edge-case.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-prepare-release-plan/tasks/basic-usage.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-prepare-release-plan/evals/trigger_tests.yaml | Removes legacy trigger test list. |
| .github/skills/azsdk-common-prepare-release-plan/evals/trigger.eval.yaml | Adds Vally trigger/anti-trigger eval spec. |
| .github/skills/azsdk-common-prepare-release-plan/evals/tasks/basic-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-prepare-release-plan/evals/tasks/anti-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-prepare-release-plan/evals/eval.yaml | Converts main eval spec to Vally stimuli/graders. |
| .github/skills/azsdk-common-prepare-release-plan/eval.yaml | Removes legacy root eval config. |
| .github/skills/azsdk-common-prepare-release-plan/SKILL.md | Flattens compatibility frontmatter. |
| .github/skills/azsdk-common-pipeline-troubleshooting/tasks/should-not-trigger.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-pipeline-troubleshooting/tasks/local-reproduction.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-pipeline-troubleshooting/tasks/edge-case.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-pipeline-troubleshooting/tasks/basic-usage.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-pipeline-troubleshooting/evals/trigger_tests.yaml | Removes legacy trigger test list. |
| .github/skills/azsdk-common-pipeline-troubleshooting/evals/trigger.eval.yaml | Adds Vally trigger/anti-trigger eval spec. |
| .github/skills/azsdk-common-pipeline-troubleshooting/evals/tasks/basic-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-pipeline-troubleshooting/evals/tasks/anti-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-pipeline-troubleshooting/evals/eval.yaml | Converts main eval spec to Vally stimuli/graders. |
| .github/skills/azsdk-common-pipeline-troubleshooting/eval.yaml | Removes legacy root eval config. |
| .github/skills/azsdk-common-pipeline-troubleshooting/SKILL.md | Flattens compatibility frontmatter. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/update-version.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/update-metadata.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/update-changelog.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/rename-client.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/hide-operation.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/full-workflow.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/edge-case.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/customization-workflow.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/breaking-changes.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/basic-usage.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/anti-trigger.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/tasks/analyzer-errors.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-generate-sdk-locally/evals/eval.yaml | Adds consolidated Vally eval spec for generate-sdk-locally skill. |
| .github/skills/azsdk-common-generate-sdk-locally/eval.yaml | Removes legacy root eval config. |
| .github/skills/azsdk-common-generate-sdk-locally/SKILL.md | Flattens compatibility frontmatter. |
| .github/skills/azsdk-common-apiview-feedback-resolution/tasks/should-not-trigger.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-apiview-feedback-resolution/tasks/no-feedback.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-apiview-feedback-resolution/tasks/edge-case.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-apiview-feedback-resolution/tasks/basic-usage.yaml | Removes legacy waza task definition. |
| .github/skills/azsdk-common-apiview-feedback-resolution/evals/trigger_tests.yaml | Removes legacy trigger test list. |
| .github/skills/azsdk-common-apiview-feedback-resolution/evals/trigger.eval.yaml | Adds Vally trigger/anti-trigger eval spec. |
| .github/skills/azsdk-common-apiview-feedback-resolution/evals/tasks/url-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-apiview-feedback-resolution/evals/tasks/basic-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-apiview-feedback-resolution/evals/tasks/anti-trigger.yaml | Removes legacy waza task. |
| .github/skills/azsdk-common-apiview-feedback-resolution/evals/eval.yaml | Converts main eval spec to Vally stimuli/graders. |
| .github/skills/azsdk-common-apiview-feedback-resolution/eval.yaml | Removes legacy root eval config. |
| .github/skills/azsdk-common-apiview-feedback-resolution/SKILL.md | Flattens compatibility frontmatter. |
| .github/skills/.waza.yaml | Removes deprecated waza project config. |
| .github/skills/.vally.yaml | Adds Vally project config (paths, environments, suites). |
haolingdong-msft
left a comment
Member
There was a problem hiding this comment.
Thanks @jeo02 for the PR, overall looks good! add some comments on impl details
927fdfb to
505ad14
Compare
This was referenced May 19, 2026
Merged
Merged
Merged
praveenkuttappan
approved these changes
May 19, 2026
jeo02
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
May 19, 2026
Sync .github/skills directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15376 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the skill evaluation infrastructure from the deprecated azd waza extension to the @microsoft/vally-cli
evaluation framework.
Changes
Eval Framework Migration
Pipeline Changes
Copilot API authentication since the copilot-sdk executor requires a user-scoped PAT (GitHub App tokens are not
supported by the Copilot API).
SKILL.md Fixes
vally lint valid-refs check)
Cleanup
Why Azure DevOps for evals?
The vally copilot-sdk executor uses @github/copilot-sdk which authenticates via the GitHub CLI (gh). The default
GITHUB_TOKEN in GitHub Actions is a GitHub App server-to-server token, which the Copilot API rejects. The ADO pipeline
accesses a user-scoped PAT (azuresdk-copilot-github-pat) from the AzSDK_Eval_Variable_group variable group.
Testing