Testing vnext Emulator#4532
Draft
FabianMeiswinkel wants to merge 1 commit into
Draft
Conversation
Member
Author
|
/azp run rust - cosmos - weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables a set of Cosmos emulator integration tests to run against the vnext emulator by removing the #[cfg_attr(test_category = "emulator_vnext", ignore = "...")] skips, increasing vnext emulator coverage for the azure_data_cosmos crate’s test suite.
Changes:
- Re-enabled multiple emulator integration tests on the
emulator_vnexttest category by removing the vnext-specificignore. - Kept the existing category gating that ignores tests unless
test_categoryisemulatororemulator_vnext. - Left the prior vnext-ignore attributes in the code as commented-out blocks (addressed in review comments as a maintainability nit).
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/azure_data_cosmos/tests/emulator_tests/cosmos_response_metadata.rs | Re-enables vnext runs for response-metadata tests by removing the vnext-only ignore. |
| sdk/cosmos/azure_data_cosmos/tests/emulator_tests/cosmos_query.rs | Re-enables vnext runs for selected query tests by removing the vnext-only ignore. |
| sdk/cosmos/azure_data_cosmos/tests/emulator_tests/cosmos_offers.rs | Re-enables vnext runs for throughput/offer tests by removing the vnext-only ignore. |
| sdk/cosmos/azure_data_cosmos/tests/emulator_tests/cosmos_items.rs | Re-enables vnext runs for multiple item CRUD/metadata tests by removing the vnext-only ignore. |
| sdk/cosmos/azure_data_cosmos/tests/emulator_tests/cosmos_feed_ranges.rs | Re-enables vnext runs for feed-range tests by removing the vnext-only ignore. |
| sdk/cosmos/azure_data_cosmos/tests/emulator_tests/cosmos_containers.rs | Re-enables vnext runs for container CRUD tests by removing the vnext-only ignore. |
| sdk/cosmos/azure_data_cosmos/tests/emulator_tests/cosmos_batch.rs | Re-enables vnext runs for a transactional batch test by removing the vnext-only ignore. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.