Skip to content

[AutoPR] reservations/resource-manager#4792

Merged
lmazuel merged 12 commits into
masterfrom
restapi_auto_reservations/resource-manager
Apr 26, 2019
Merged

[AutoPR] reservations/resource-manager#4792
lmazuel merged 12 commits into
masterfrom
restapi_auto_reservations/resource-manager

Conversation

@AutorestCI

@AutorestCI AutorestCI commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

Created to accumulate context: reservations/resource-manager

@AutorestCI
[AutoPR reservations/resource-manager] [Hub Generated] Review request…
9db8bf0 
… for Microsoft.Capacity to add version 2019-04-01 (#4590)

* Generated from 7dc9733827a5e8f86614319c9b6756ec8aa11dc8

long running operation

* Packaging update of azure-mgmt-reservations

* Generated from 286d851c9a3c7101d44152f7fa706369b31299d6

update api version

* Generated from 4908a3829756b457cb0b7a0261a04dbd2598c7a2

fix ref

* Generated from 78a2d4b2c9d236f784254c1d5dcb9ff1e3033bda

change parameter name

* Generated from 6afc6414e898ac8b2ae326f70ca82f5fc865bd34

descriptions

* Generated from 71c3c06d880ad26fdf9bd0fb512096e110b897b7

updated description

* Generated from b95fb24f7cf665582d599709c431aedbe20e824f

minor description update

* Packaging update of azure-mgmt-reservations
@AutorestCI
AutorestCI requested a review from lmazuel as a code owner April 5, 2019 23:52
This was referenced Apr 5, 2019
Merged
Merged
@AutorestCI

AutorestCI commented Apr 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-reservations

You can install the package azure-mgmt-reservations of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_reservations/resource-manager#egg=azure-mgmt-reservations&subdirectory=azure-mgmt-reservations"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_reservations/resource-manager#egg=azure-mgmt-reservations&subdirectory=azure-mgmt-reservations"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_reservations/resource-manager
  • pip install -e ./azure-mgmt-reservations

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_reservations/resource-manager
  • pip wheel --no-deps ./azure-mgmt-reservations

Direct download

Your files can be directly downloaded here:

@AutorestCI AutorestCI mentioned this pull request Apr 6, 2019
Merged
@AutorestCI
Generated from 2a27c087f73db194c6bc57747665dc2f62e2d6f4 (#4794)
e10fc7b 
fix: reservations\resource-manager\Microsoft.Capacity

- Remove trailing newline in description
- specificed -> specified
@AutorestCI AutorestCI mentioned this pull request Apr 8, 2019
Merged
This was referenced Apr 15, 2019
Closed
Closed
Merged
@AutorestCI AutorestCI mentioned this pull request Apr 15, 2019
Merged
@iscai-msft

iscai-msft commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/reservations/resource-manager/readme.md

@AutorestCI

AutorestCI commented Apr 18, 2019

Copy link
Copy Markdown
Contributor Author

Nothing to rebuild, this PR is up to date

@iscai-msft
updated change log
8ff938d
@iscai-msft
Merge branch 'restapi_auto_reservations/resource-manager' of github.c…
6c43961 
…om:Azure/azure-sdk-for-python into restapi_auto_reservations/resource-manager
@corquiri

corquiri commented Apr 19, 2019

Copy link
Copy Markdown

@iscai-msft @lmazuel could you please help me understand what is blocking merge of this PR?? Is it CI build failure? I tried looking into log but it is simply too long my browser cannot load everything. Can you please help me proceed with this PR?

@AutorestCI AutorestCI mentioned this pull request Apr 19, 2019
Merged
2 tasks
@AutorestCI AutorestCI mentioned this pull request Apr 22, 2019
Merged
@iscai-msft

iscai-msft commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

@corquiri the PR is blocked because the tests need to be re-recorded using the new API. The tests will be re-recorded soon and the CI should pass after that and the PR can be merged. Thanks!

@corquiri

corquiri commented Apr 23, 2019

Copy link
Copy Markdown

we are waiting for one change from REST-Specs Repo to propagate here. I will work on after that change is applied.

@AutorestCI AutorestCI mentioned this pull request Apr 23, 2019
Merged
2 tasks
@AutorestCI
Generated from 7f6156ebc084d5957701544e764be834af2c3228 (#4942)
2c79059 
FW: [Revert][Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 (#5715)
@AutorestCI AutorestCI mentioned this pull request Apr 23, 2019
Merged
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
41e05e3 
…into restapi_auto_reservations/resource-manager
@corquiri

corquiri commented Apr 25, 2019

Copy link
Copy Markdown

@lmazuel @iscai-msft can we please merge this PR now? I've fixed the unit tests

@corquiri

corquiri commented Apr 25, 2019

Copy link
Copy Markdown

I also want to consume this package in CLI ASAP, do I need to publish this to somewhere?

@lmazuel
lmazuel merged commit e8350ce into master Apr 26, 2019
@lmazuel
lmazuel deleted the restapi_auto_reservations/resource-manager branch April 26, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

No one assigned

Labels

ServicePR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AutorestCI @iscai-msft @corquiri @lmazuel