[Identity] Retry IMDS requests on 410 responses - #32200
Merged
Merged
Conversation
There are cases where the IMDS endpoint might return a 410 error response, and the guidance is to retry on such an error. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Paul Van Eck (pvaneck)
force-pushed
the
imds-410
branch
from
September 22, 2023 22:45
8632396 to
100d18a
Compare
Paul Van Eck (pvaneck)
marked this pull request as ready for review
September 22, 2023 22:48
Paul Van Eck (pvaneck)
requested review from
a team and
Xiang Yan (xiangyan99)
as code owners
September 22, 2023 22:48
Collaborator
|
API change check API changes are not detected in this pull request. |
Xiang Yan (xiangyan99)
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where the IMDS endpoint might return a 410 error response, and the guidance is to retry on such an error.
.NET has already implemented a similar PR: Azure/azure-sdk-for-net#37012
Note: The
Retry-Afterheader was removed from the test responses since our RetryPolicy will retry any error response with this header. In our test cases, we want to test the retry based only on the status code.