add wam support - #25944
Merged
Merged
Conversation
ghost
added
the 
Member
Author
Xiang Yan (xiangyan99)
marked this pull request as ready for review
August 29, 2022 21:47
Xiang Yan (xiangyan99)
requested review from
Laia Patiño (laiapat) and
Scott Schaab (schaabs)
as code owners
August 29, 2022 21:47
Laia Patiño (laiapat)
left a comment
Laia Patiño (laiapat)
left a comment
Member
There was a problem hiding this comment.
Are there any tests we can add for this? At least for verifying that the kwarg gets passed along correctly?
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
…icate.py Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Laia Patiño (laiapat)
approved these changes
Aug 30, 2022
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Xiang Yan (xiangyan99)
requested a review
from Paul Van Eck (pvaneck)
as a code owner
November 16, 2022 19:38
Paul Van Eck (pvaneck)
left a comment
Paul Van Eck (pvaneck)
left a comment
Member
There was a problem hiding this comment.
Is there any documentation or a sample about usage of the allow_broker arg we can provide for users?
Paul Van Eck (pvaneck)
left a comment
Paul Van Eck (pvaneck)
left a comment
Member
There was a problem hiding this comment.
I see that the param was removed from DeviceCodeCredential doc string. I take it WAM is not supported with DeviceCodeCredential?
…r.py Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
…assword.py Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
Paul Van Eck (pvaneck)
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines