ACR 2017-10-01

[lmazuel]

@djyou Ready for tests and review on your side

[lmazuel]

@djyou This error means that you leaked an AzureOperationPoller unfinished from one of your tests. Be sure to explictly call wait or result on all the AzureOperationPoller before the end of the tests.

Note that we have a task to add in the test framework the detection of that and a more detailled exception, but still not done yet.

[codecov-io]

Codecov Report

Merging #1455 into master will increase coverage by 0.26%.
The diff coverage is 87.17%.

@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
+ Coverage    55.1%   55.36%   +0.26%     
==========================================
  Files        3417     3571     +154     
  Lines       83477    87414    +3937     
==========================================
+ Hits        45996    48393    +2397     
- Misses      37481    39021    +1540

Impacted Files	Coverage Δ
...mgmt/containerregistry/v2017_10_01/models/event.py	57.14% <ø> (ø)
...ntainerregistry/v2017_10_01/operations/__init__.py	100% <ø> (ø)
...tainerregistry/v2017_10_01/models/event_content.py	36.36% <ø> (ø)
...ry/v2017_10_01/models/webhook_update_parameters.py	100% <ø> (ø)
...ontainerregistry/v2017_10_01/models/replication.py	100% <ø> (ø)
...y/v2017_10_01/models/storage_account_properties.py	100% <ø> (ø)
...inerregistry/v2017_10_01/models/callback_config.py	100% <ø> (ø)
...t/containerregistry/v2017_10_01/models/resource.py	100% <ø> (ø)
...erregistry/v2017_10_01/models/replication_paged.py	100% <ø> (ø)
...v2017_10_01/models/operation_display_definition.py	50% <ø> (ø)
... and 217 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e550f...c7e1e8e. Read the comment docs.

[derekbekoe]

@djyou @lmazuel I will restart CI for the PR after Azure/azure-cli#4523 has been merged.

[derekbekoe]

Restarted.

[djyou]

@derekbekoe Do you know why one of the CI couldn't start properly?

[djyou]

This file build.json seems to be outdated since the previous version. Other than that, this PR is good to go.