Deprecate UsernamePasswordCredential - #44381
Merged
Bill Wert (billwert) merged 15 commits intoMar 8, 2025
Merged
Conversation
Due to changes around how MFA is required in Azure tenants, UsernamePasswordCredential is no longer recommended.
Bill Wert (billwert)
requested review from
a team,
Vinay Gera (g2vinay) and
Josh Free (joshfree)
as code owners
February 25, 2025 00:49
Collaborator
|
API change check API changes are not detected in this pull request. |
Paul Van Eck (pvaneck)
left a comment
Paul Van Eck (pvaneck)
left a comment
Member
There was a problem hiding this comment.
Hey, some additional changes that were made in Python could also be made here:
- Update README.md to mark the credential Deprecated in the credential list and a note in the
Environment variablessection regarding username + password authentication. - A note in the EnvironmentCredential docstring under the username + password portion about this mode of authentication being deprecated.
…sernamePasswordCredential.java Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
…sernamePasswordCredentialBuilder.java Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Bill Wert (billwert)
requested review from
Paul Van Eck (pvaneck) and
Scott Addie (scottaddie)
February 26, 2025 00:11
Paul Van Eck (pvaneck)
approved these changes
Feb 26, 2025
Paul Van Eck (pvaneck)
left a comment
Paul Van Eck (pvaneck)
left a comment
Member
There was a problem hiding this comment.
I think just missing one more deprecated disclaimer in the Environment variables ### Username and password section of the readme, but otherwise LGTM.
Bill Wert (billwert)
requested review from
Muyao Feng (Netyyyy),
Moary Chen (moarychan),
Rujun Chen (rujche) and
Xiaolu Dai (saragluna)
as code owners
February 26, 2025 20:02
Scott Addie (scottaddie)
approved these changes
Feb 27, 2025
Contributor
Author
|
Xiaolu Dai (@saragluna) ptal for the changes to spring files. |
Xiaolu Dai (saragluna)
left a comment
Xiaolu Dai (saragluna)
left a comment
Member
There was a problem hiding this comment.
LGTM for the Spring changes.
Scott Addie (scottaddie)
approved these changes
Mar 7, 2025
github-project-automation
Bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Azure/azure-sdk-for-java-pr/issues/1432
Due to changes around how MFA is required in Azure tenants, UsernamePasswordCredential is no longer recommended.