New data loader#41539
Closed
mrm9084 wants to merge 1427 commits into
Closed
Conversation
mrm9084
requested review from
JonathanGiles,
Netyyyy,
alzimmermsft,
g2vinay,
rujche and
samvaity
as code owners
saragluna
reviewed
Nov 21, 2024
| "org.springframework.boot.actuate.autoconfigure.endpoint.web.WebEndpointProperties", | ||
| "org.springframework.cloud.endpoint.RefreshEndpoint" | ||
| }) | ||
| @Deprecated |
Member
There was a problem hiding this comment.
Given it's a major release, do we consider removing them?
| * @param configStores configuration info for config stores | ||
| */ | ||
| public AppConfigurationReplicaClientFactory(AppConfigurationReplicaClientsBuilder clientBuilder, | ||
| AppConfigurationReplicaClientFactory(AppConfigurationReplicaClientsBuilder clientBuilder, |
Member
There was a problem hiding this comment.
Looks like a little bit weird the factory depends on a builder here?
Member
Author
There was a problem hiding this comment.
Yeah, I think it's a naming issue, one creates the App Config Store stuff where each store has multiple instances of individual clients, which the other makes.
Contributor
There was a problem hiding this comment.
Copilot reviewed 47 out of 62 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- eng/versioning/external_dependencies.txt: Language not supported
- sdk/spring/spring-cloud-azure-appconfiguration-config/pom.xml: Language not supported
- sdk/spring/spring-cloud-azure-appconfiguration-config-web/src/test/java/com/azure/spring/cloud/appconfiguration/config/web/implementation/AppConfigurationWebAutoConfigurationTest.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySourceLocator.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config-web/src/main/java/com/azure/spring/cloud/appconfiguration/config/web/implementation/pushbusrefresh/AppConfigurationBusRefreshEventListener.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config-web/src/main/java/com/azure/spring/cloud/appconfiguration/config/web/implementation/pushrefresh/AppConfigurationRefreshEventListener.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config-web/src/main/java/com/azure/spring/cloud/appconfiguration/config/web/implementation/AppConfigurationWebAutoConfiguration.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config-web/src/main/java/com/azure/spring/cloud/appconfiguration/config/web/implementation/pullrefresh/AppConfigurationEventListener.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientFactory.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationSnapshotPropertySource.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationRefreshUtil.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationKeyVaultClientFactory.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-appconfiguration-config-web/src/main/java/com/azure/spring/cloud/appconfiguration/config/web/implementation/pushrefresh/AppConfigurationRefreshEndpoint.java: Evaluated as low risk
Comments skipped due to low confidence (2)
sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigBoostrapRegistrar.java:1
- The class name 'AzureAppConfigBoostrapRegistrar' contains a typo. It should be 'AzureAppConfigBootstrapRegistrar'.
class AzureAppConfigBoostrapRegistrar {
sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClient.java:204
- The method name 'hanndleHttpResponseException' contains a spelling mistake. It should be 'handleHttpResponseException'.
private HttpResponseException hanndleHttpResponseException(HttpResponseException e) {
Update pipeline and version tooling to support clientcore
… azure-cosmos-encryption (Azure#43785) * Release Changes * Fix pom files
…on (Azure#43784) Co-authored-by: Scott Beddall <scbedd@microsoft.com>
mrm9084
requested review from
a team,
ArthurMa1978,
JimSuplizio,
XiaofeiCao,
anuchandy,
benbp,
conniey,
dargilco,
glharper,
hallipr,
haolingdong-msft,
jhakulin,
joshfree,
kirankumarkolli,
lmolkova,
mengaims,
mssfang,
srnagar,
vcolin7,
weidongxu-microsoft and
weshaggard
as code owners
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines