Skip to content

Sync eng/common directory with azure-sdk-tools for PR 15995#7165

Merged
praveenkuttappan merged 1 commit into
mainfrom
sync-eng-common-samvaity/mcp-fallback-on-upgrade-failure-15995
Jun 15, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 15995#7165
praveenkuttappan merged 1 commit into
mainfrom
sync-eng-common-samvaity/mcp-fallback-on-upgrade-failure-15995

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15995 See eng/common workflow

When the upgrade check or installation fails (due to GitHub API rate
limiting, 504 timeouts, or network errors), fall back to the existing
binary instead of exiting with an error. This prevents the MCP client
from respawning the process in a tight loop that can spawn hundreds of
pwsh processes.

Changes:
- Check ~/bin (default install dir) when binary is not on PATH
- Use azsdkCmd.Path instead of package name for upgrade check
- On upgrade check failure in -Run mode, fall back to existing binary
- On Install-Standalone-Tool failure in MCP mode, fall back to existing
  binary if available at the known install directory

Fixes #15973
Fixes #15953

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 15, 2026 17:34
@azure-sdk-automation azure-sdk-automation Bot requested a review from a team as a code owner June 15, 2026 17:34
@azure-sdk-automation azure-sdk-automation Bot requested a review from samvaity June 15, 2026 17:34
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Jun 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@praveenkuttappan praveenkuttappan merged commit 6b6e56a into main Jun 15, 2026
87 of 89 checks passed
@praveenkuttappan praveenkuttappan deleted the sync-eng-common-samvaity/mcp-fallback-on-upgrade-failure-15995 branch June 15, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants