added missing Swagger by gatneil · Pull Request #2428 · Azure/azure-rest-api-specs

gatneil · 2018-02-06T06:40:36Z

No description provided.

azuresdkciprbot · 2018-02-06T06:44:52Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 39
After the PR: Warning(s): 0 Error(s): 38

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-06T06:48:34Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1930

olydis

some comments 🙂

olydis · 2018-02-06T17:57:42Z

+        "tags": [
+          "ComputeOperations"
+        ],
+        "operationId": "ComputeOperations_List",


pretty sure it is convention to call this Operations_List; @ravbhatnagar ?

yes thats correct

fix incoming

olydis · 2018-02-06T17:59:15Z

  "paths": {
+    "/providers/Microsoft.Compute/operations": {
+      "get": {
+        "tags": [


mark this operation as

"x-ms-pageable": { "nextLinkName": null },

to hide the wrapping of ComputeOperationListResult from users. Just to confirm: There are no further pages in the result, i.e. you'll return just one page?

yup! just one page; fix incoming

olydis · 2018-02-06T18:01:12Z

+            "schema": {
+              "$ref": "#/definitions/AvailabilitySet"
+            }
+          }


just caught my eye because it's different from the others: this PATCH is not long running?

nope! it always returns immediately :)

olydis · 2018-02-06T18:02:05Z

+    "ComputeOperationListResult": {
+      "properties": {
+        "value": {
+          "type": "array",


please mark as readOnly

fix incoming

olydis · 2018-02-06T18:05:41Z

+      "description": "The List Compute Operation operation response."
+    },
+    "ComputeOperationValue": {
+      "properties": {


mark all properties as readOnly, same for next type

(since they are only ever received from the service, not sent to it)

fix incoming

olydis · 2018-02-06T18:07:26Z

@ravbhatnagar some new operations; I already did a quick SDK-goggles run over it since it's not a lot of changes

olydis · 2018-02-15T21:12:02Z

@ravbhatnagar ping

ravbhatnagar · 2018-02-15T22:24:23Z

Looks good!

olydis · 2018-02-20T23:59:07Z

@gatneil ping

AutorestCI · 2018-02-21T07:20:05Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1366

gatneil · 2018-02-21T08:26:16Z

@olydis sorry for the delay; thoughts on the latest and greatest? :)

lmazuel · 2018-02-21T20:01:01Z

@AutorestCI rebuild azure-sdk-for-python

olydis

Looking good overall, thanks for the fixes! Just a minor comment 😉

olydis · 2018-02-22T22:51:07Z

+          "$ref": "#/definitions/VirtualMachineProperties"
+        },
+        "resources": {
+          "readOnly": true,


what does it mean for a property of VirtualMachineUpdate (if I see correctly, only ever sent) to be readOnly? 😃

Yup, you're right. It makes no sense, so I removed it. Originally, I copied that from the VirtualMachine object, which is used in GETs as well, so it makes sense to have it in that object as readOnly, but it doesn't make sense for the VirtualMachineUpdate object :)

lmazuel · 2018-03-13T23:15:48Z

@AutorestCI rebuild azure-sdk-for-python

jhendrixMSFT · 2018-03-16T17:57:50Z

@AutorestCI rebuild azure-sdk-for-go

AutorestCI · 2018-03-16T18:00:20Z

Encountered a Subprocess error

Command: ['/usr/local/bin/autorest', '/tmp/tmpekhqdq7p/rest/specification/compute/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpekhqdq7p/sdk', '--multiapi', '--package-version=latest', '--use=@microsoft.azure/autorest.go@~2.1.87', "--user-agent='Azure-SDK-For-Go/latest services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4255/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4255)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.87->2.1.88)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-disks-2018-04"} .
Processing batch task - {"tag":"package-2017-12"} .
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StorageAccountTypes' and different values: Standard_LRS,Premium_LRS vs. Standard_LRS,Premium_LRS
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 147
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 271
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
Failure during batch task - {"tag":"package-2017-12"} -- Error: Plugin imodeler1 reported failure..
  Error: Plugin imodeler1 reported failure.

AutorestCI · 2018-03-20T02:54:45Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2495

AutorestCI · 2018-03-20T02:55:08Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
Azure/azure-libraries-for-java#273

gatneil · 2018-03-20T03:05:20Z

@olydis thanks for your patience! How's it look now? :)

olydis

LGTM

added missing Swagger

9433e42

azuresdkci assigned olydis Feb 6, 2018

AutorestCI mentioned this pull request Feb 6, 2018

[AutoPR compute/resource-manager] added missing Swagger Azure/azure-sdk-for-python#1910

Closed

olydis reviewed Feb 6, 2018

View reviewed changes

olydis added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 15, 2018

olydis added the Reviewed-FeedbackProvided label Feb 16, 2018

fixed PATCH to no longer require location

0de4784

AutorestCI mentioned this pull request Feb 21, 2018

[AutoPR compute/resource-manager] added missing Swagger Azure/azure-sdk-for-go#1106

Closed

removed invalid 'required' properties

d8bed83

Azure deleted a comment from AutorestCI Feb 21, 2018

AutorestCI mentioned this pull request Feb 21, 2018

[AutoPR compute/resource-manager] added missing Swagger Azure/azure-sdk-for-python#2024

Closed

olydis reviewed Feb 22, 2018

View reviewed changes

AutorestCI mentioned this pull request Mar 13, 2018

[AutoPR compute/resource-manager] added missing Swagger Azure/azure-sdk-for-python#2163

Closed

removed readOnly patchOnly property

5ef2236

gatneil requested a review from a user March 20, 2018 02:47

gatneil requested review from DeepakRajendranMsft, shawns1, tbombach, tiffanyachen and vladbarosan as code owners March 20, 2018 02:47

AutorestCI mentioned this pull request Mar 20, 2018

[AutoPR compute/resource-manager] added missing Swagger Azure/azure-sdk-for-node#2474

Merged

AutorestCI mentioned this pull request Mar 20, 2018

[AutoPR compute/resource-manager] added missing Swagger Azure/azure-libraries-for-java#342

Merged

olydis approved these changes Mar 20, 2018

View reviewed changes

olydis merged commit fed8272 into Azure:master Mar 20, 2018

AutorestCI mentioned this pull request Mar 20, 2018

[AutoPR compute/resource-manager] added missing Swagger Azure/azure-sdk-for-go#1365

Merged

anuchandy mentioned this pull request Apr 11, 2018

added suppressions #2848

Merged

Uh oh!

Conversation

gatneil commented Feb 6, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azuresdkciprbot commented Feb 6, 2018

Uh oh!

AutorestCI commented Feb 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

olydis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olydis commented Feb 6, 2018

Uh oh!

olydis commented Feb 15, 2018

Uh oh!

ravbhatnagar commented Feb 15, 2018

Uh oh!

olydis commented Feb 20, 2018

Uh oh!

AutorestCI commented Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

gatneil commented Feb 21, 2018

Uh oh!

lmazuel commented Feb 21, 2018

Uh oh!

olydis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmazuel commented Mar 13, 2018

Uh oh!

jhendrixMSFT commented Mar 16, 2018

Uh oh!

AutorestCI commented Mar 16, 2018

Uh oh!

AutorestCI commented Mar 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Mar 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

gatneil commented Mar 20, 2018

Uh oh!

olydis left a comment

Choose a reason for hiding this comment

Uh oh!

gatneil commented Feb 6, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Feb 6, 2018 •

edited

Loading

AutorestCI commented Feb 21, 2018 •

edited

Loading

AutorestCI commented Mar 20, 2018 •

edited

Loading

AutorestCI commented Mar 20, 2018 •

edited

Loading