[Napster] Initial AutoRest-generated release of Az.Napster module#29730
Open
yashikajain14 wants to merge 1 commit into
Open
[Napster] Initial AutoRest-generated release of Az.Napster module#29730yashikajain14 wants to merge 1 commit into
yashikajain14 wants to merge 1 commit into
Conversation
Generated Az.Napster module from Napster.CompanionAPI swagger (commit 7950f0f1c6372cb09de2961797bdef2d7ceda991). Cmdlets: - Get-AzNapsterOrganization - New-AzNapsterOrganization - Update-AzNapsterOrganization - Remove-AzNapsterOrganization - Invoke-AzNapsterLinkOrganizationSaaS - Invoke-AzNapsterLatestOrganizationLinkedSaaS - Initialize-AzNapsterSaaSOperationGroupResource Tests recorded against subscription 61641157-140c-4b97-b365-30ff76d9f82e in resource group acctest0001. All 9 tests pass in playback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR introduces the new Az.Napster PowerShell module scaffolding, including module packaging assets, generated help/docs content, and Pester tests/recordings, and registers the module in the mappings rules.
Changes:
- Added
Az.Napstermodule project/manifest/changelog and solution wiring. - Added generated cmdlet help markdown, examples, AutoRest module scaffolding, and UX metadata.
- Added Pester tests, recordings, and test utilities for
Az.Napstercmdlets.
Reviewed changes
Copilot reviewed 58 out of 60 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/CreateMappings_rules.json | Registers the new Napster module mapping. |
| src/Napster/Napster/help/Update-AzNapsterOrganization.md | Adds user-facing help for Update-AzNapsterOrganization. |
| src/Napster/Napster/help/Remove-AzNapsterOrganization.md | Adds user-facing help for Remove-AzNapsterOrganization. |
| src/Napster/Napster/help/New-AzNapsterOrganization.md | Adds user-facing help for New-AzNapsterOrganization. |
| src/Napster/Napster/help/Invoke-AzNapsterLinkOrganizationSaaS.md | Adds user-facing help for linking a SaaS to an organization. |
| src/Napster/Napster/help/Invoke-AzNapsterLatestOrganizationLinkedSaaS.md | Adds user-facing help for retrieving latest linked SaaS. |
| src/Napster/Napster/help/Initialize-AzNapsterSaaSOperationGroupResource.md | Adds user-facing help for SaaS activation flow. |
| src/Napster/Napster/help/Get-AzNapsterOrganization.md | Adds user-facing help for Get-AzNapsterOrganization. |
| src/Napster/Napster/help/Az.Napster.md | Adds module landing help page for Az.Napster. |
| src/Napster/Napster/Properties/AssemblyInfo.cs | Adds assembly metadata for the Napster wrapper project. |
| src/Napster/Napster/Napster.csproj | Adds the SDK-style project for packaging the module assets. |
| src/Napster/Napster/ChangeLog.md | Adds changelog with initial preview release entry. |
| src/Napster/Napster/Az.Napster.psd1 | Adds the module manifest including exports and dependencies. |
| src/Napster/Napster.sln | Adds solution scaffolding including Napster and generated AutoRest project. |
| src/Napster/Napster.Autorest/utils/Unprotect-SecureString.ps1 | Adds a utility to convert SecureString to plaintext. |
| src/Napster/Napster.Autorest/utils/Get-SubscriptionIdTestSafe.ps1 | Adds a helper to fetch subscription id safely in playback/live modes. |
| src/Napster/Napster.Autorest/test/utils.ps1 | Adds test helpers and environment setup for Pester tests. |
| src/Napster/Napster.Autorest/test/loadEnv.ps1 | Adds env loader for tests (record/playback/live). |
| src/Napster/Napster.Autorest/test/env.json | Adds committed test environment defaults for playback. |
| src/Napster/Napster.Autorest/test/Update-AzNapsterOrganization.Tests.ps1 | Adds Pester test for update cmdlet. |
| src/Napster/Napster.Autorest/test/Remove-AzNapsterOrganization.Tests.ps1 | Adds Pester test for remove cmdlet. |
| src/Napster/Napster.Autorest/test/Remove-AzNapsterOrganization.Recording.json | Adds recorded HTTP interaction for remove cmdlet playback. |
| src/Napster/Napster.Autorest/test/README.md | Adds guidance for module test modes and usage. |
| src/Napster/Napster.Autorest/test/New-AzNapsterOrganization.Tests.ps1 | Adds Pester test for create cmdlet. |
| src/Napster/Napster.Autorest/test/Invoke-AzNapsterLinkOrganizationSaaS.Tests.ps1 | Adds Pester test for link SaaS cmdlet. |
| src/Napster/Napster.Autorest/test/Invoke-AzNapsterLinkOrganizationSaaS.Recording.json | Adds recorded HTTP interactions for link SaaS playback. |
| src/Napster/Napster.Autorest/test/Invoke-AzNapsterLatestOrganizationLinkedSaaS.Tests.ps1 | Adds Pester test for latest linked SaaS cmdlet. |
| src/Napster/Napster.Autorest/test/Invoke-AzNapsterLatestOrganizationLinkedSaaS.Recording.json | Adds recorded HTTP interaction for latest linked SaaS playback. |
| src/Napster/Napster.Autorest/test/Initialize-AzNapsterSaaSOperationGroupResource.Tests.ps1 | Adds Pester test for SaaS activation cmdlet. |
| src/Napster/Napster.Autorest/test/Get-AzNapsterOrganization.Tests.ps1 | Adds Pester tests for get/list variants. |
| src/Napster/Napster.Autorest/resources/README.md | Adds repository-only resources folder README. |
| src/Napster/Napster.Autorest/how-to.md | Adds contributor how-to for build/test/pack workflows. |
| src/Napster/Napster.Autorest/generate-info.json | Adds generation metadata for AutoRest output. |
| src/Napster/Napster.Autorest/examples/Update-AzNapsterOrganization.md | Adds examples content for update cmdlet docs. |
| src/Napster/Napster.Autorest/examples/Remove-AzNapsterOrganization.md | Adds examples content for remove cmdlet docs. |
| src/Napster/Napster.Autorest/examples/New-AzNapsterOrganization.md | Adds examples content for create cmdlet docs. |
| src/Napster/Napster.Autorest/examples/Invoke-AzNapsterLinkOrganizationSaaS.md | Adds examples content for link SaaS cmdlet docs. |
| src/Napster/Napster.Autorest/examples/Invoke-AzNapsterLatestOrganizationLinkedSaaS.md | Adds examples content for latest linked SaaS docs. |
| src/Napster/Napster.Autorest/examples/Initialize-AzNapsterSaaSOperationGroupResource.md | Adds examples content for SaaS activation docs. |
| src/Napster/Napster.Autorest/examples/Get-AzNapsterOrganization.md | Adds examples content for get/list docs. |
| src/Napster/Napster.Autorest/docs/Update-AzNapsterOrganization.md | Adds generated cmdlet reference docs for update. |
| src/Napster/Napster.Autorest/docs/Remove-AzNapsterOrganization.md | Adds generated cmdlet reference docs for remove. |
| src/Napster/Napster.Autorest/docs/README.md | Adds generated docs folder README. |
| src/Napster/Napster.Autorest/docs/New-AzNapsterOrganization.md | Adds generated cmdlet reference docs for create. |
| src/Napster/Napster.Autorest/docs/Invoke-AzNapsterLinkOrganizationSaaS.md | Adds generated cmdlet reference docs for link SaaS. |
| src/Napster/Napster.Autorest/docs/Invoke-AzNapsterLatestOrganizationLinkedSaaS.md | Adds generated cmdlet reference docs for latest linked SaaS. |
| src/Napster/Napster.Autorest/docs/Initialize-AzNapsterSaaSOperationGroupResource.md | Adds generated cmdlet reference docs for SaaS activation. |
| src/Napster/Napster.Autorest/docs/Get-AzNapsterOrganization.md | Adds generated cmdlet reference docs for get/list. |
| src/Napster/Napster.Autorest/docs/Az.Napster.md | Adds generated module landing doc page. |
| src/Napster/Napster.Autorest/custom/README.md | Adds custom cmdlets guidance for AutoRest module structure. |
| src/Napster/Napster.Autorest/custom/Az.Napster.custom.psm1 | Adds loader/export wiring for custom cmdlets. |
| src/Napster/Napster.Autorest/UX/Napster.CompanionAPI/organizations.json | Adds UX metadata for organizations commands. |
| src/Napster/Napster.Autorest/README.md | Adds AutoRest module readme and configuration snippet. |
| src/Napster/Napster.Autorest/Properties/AssemblyInfo.cs | Adds generated assembly metadata for AutoRest project. |
| src/Napster/Napster.Autorest/.gitignore | Adds ignore rules for generated/build outputs within AutoRest module folder. |
| src/Napster/Napster.Autorest/.gitattributes | Adds default text normalization rules. |
Comments suppressed due to low confidence (7)
src/Napster/Napster.Autorest/test/loadEnv.ps1:1
- The fallback path uses single quotes (
'..\\$envFile'), so$envFilewon’t expand and the computed$envFilePathwill be incorrect. Additionally, the JSON is read from(Join-Path $PSScriptRoot $envFile)instead of the resolved$envFilePath, which defeats the fallback logic. Use a path construction that expands variables and read from$envFilePathconsistently.
src/Napster/Napster.Autorest/utils/Unprotect-SecureString.ps1:1 - This utility converts
SecureStringto plaintext and returns it, which increases the risk of secrets exposure (logs, transcripts, crash dumps, etc.), especially if this ends up packaged with the module. If this is only needed for local testing, consider moving it under the test-only path, ensure it’s not exported/packaged, and add prominent warnings (or remove it entirely if not required).
src/Napster/Napster/Properties/AssemblyInfo.cs:1 - Use the correct product capitalization: change
PowershelltoPowerShellin the assembly title string to match standard Microsoft naming.
src/Napster/Napster.Autorest/test/env.json:1 - This committed test configuration includes potentially sensitive/identifying information (personal email, tenant/subscription IDs). If these are not intended to be public/stable, prefer using sanitized placeholders for playback mode and loading real values from secure CI variables for record/live runs.
src/Napster/Napster.Autorest/test/env.json:1 - This committed test configuration includes potentially sensitive/identifying information (personal email, tenant/subscription IDs). If these are not intended to be public/stable, prefer using sanitized placeholders for playback mode and loading real values from secure CI variables for record/live runs.
src/Napster/Napster.Autorest/test/utils.ps1:1 - Within
setupEnv,SubscriptionIdis assigned fromGet-AzContextand then immediately overwritten with a hard-coded value. This makes the intent unclear and can lead to surprising behavior (especially in live/record). Consider using one source of truth (either context-derived, or file/CI-driven), and avoid redundant assignments.
src/Napster/Napster/help/Get-AzNapsterOrganization.md:1 - Grammar in the synopsis (and similar lines across the new help/docs files) should be
Get an OrganizationResource/Create an OrganizationResource/Delete an OrganizationResourceetc. Updating these improves consistency and professionalism in published help.
Comment on lines
+1
to
+7
| --- | ||
| Module Name: Az.Napster | ||
| Module Guid: f400c2bc-36af-404b-8a98-722efc7dd851 | ||
| Download Help Link: https://learn.microsoft.com/powershell/module/az.napster | ||
| Help Version: 1.0.0.0 | ||
| Locale: en-US | ||
| --- |
Contributor
Author
There was a problem hiding this comment.
This is autogenerated from autorest
Comment on lines
+10
to
+16
| /*.ps1 | ||
| /*.psd1 | ||
| /*.ps1xml | ||
| /*.psm1 | ||
| /*.snk | ||
| /*.csproj | ||
| /*.nuspec No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
This is autogenerated from autorest.
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Looks good, pending onboarding to mcr (PR 5091) prior to approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Az.Napster module from Napster.CompanionAPI swagger (commit 7950f0f1c6372cb09de2961797bdef2d7ceda991).
Cmdlets:
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.