Skip to content

Az Alb 2023-11-01#23449

Closed
malpaniHMC wants to merge 1 commit into
Azure:generationfrom
malpaniHMC:shmalpani/2023-11-01-generation
Closed

Az Alb 2023-11-01#23449
malpaniHMC wants to merge 1 commit into
Azure:generationfrom
malpaniHMC:shmalpani/2023-11-01-generation

Conversation

@malpaniHMC

Copy link
Copy Markdown

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd

Copy link
Copy Markdown
Validation for PowerShell Core and Windows PowerShell Starts. Thanks for your contribution!

@NoriZC

NoriZC commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Hi @malpaniHMC, we are now updating the folder structure of all modules. Please expect this pr to fail to CIs and we will let you know how to handle with the conflict tomorrow. Thanks.

@NoriZC NoriZC self-assigned this Nov 16, 2023
@wyunchi-ms

Copy link
Copy Markdown
Contributor

Hi @malpaniHMC , we have update the folder structure of the modules of Azure PowerShell. For your PR, please follow these steps:

  1. Copy the folder of your module xxx to a tmp folder
  2. Create a new branch base on the latest generation branch
  3. Move the copied folder in step 1 to the folder xxx/xxx.Autorest
  4. Raise another PR for the new branch
  5. Close the old PR

@NoriZC

NoriZC commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

Replaced by #23479

@NoriZC NoriZC closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants