Skip to content

ApiManagement - new verison 2020-12-01 update#15524

Merged
VeryEarly merged 17 commits into
Azure:mainfrom
KacieKK:jikang/20201201
Aug 4, 2021
Merged

ApiManagement - new verison 2020-12-01 update#15524
VeryEarly merged 17 commits into
Azure:mainfrom
KacieKK:jikang/20201201

Conversation

@KacieKK

@KacieKK KacieKK commented Jul 23, 2021

Copy link
Copy Markdown
Contributor

Description

update to latest SDK

Checklist

@KacieKK KacieKK requested a review from solankisamir July 23, 2021 00:05
@isra-fel isra-fel self-assigned this Jul 23, 2021

@isra-fel isra-fel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the log of CI suggests, please fix 2 issues in help documents

Target      : New-AzApiManagementKeyVaultObject.md
  Description : Online version in the header of the file is incorrect. The 
                corresponding URL should be the following: https://docs.microsoft
                .com/powershell/module/az.apimanagement/new-azapimanagementkeyvau
                ltobject
  
  Target      : Sync-AzApiManagementKeyVaultSecret.md
  Description : Online version in the header of the file is incorrect. The 
                corresponding URL should be the following: https://docs.microsoft
                .com/powershell/module/az.apimanagement/sync-azapimanagementkeyva
                ultsecret

Comment thread src/ApiManagement/ApiManagement/Az.ApiManagement.psd1 Outdated
Comment thread src/ApiManagement/ApiManagement/Commands/NewAzureApiManagement.cs Outdated
@isra-fel

Copy link
Copy Markdown
Member

Besides, some scenario tests are failing

@solankisamir

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Commenter does not have sufficient privileges for PR 15524 in repo Azure/azure-powershell

@KacieKK KacieKK removed their assignment Jul 30, 2021
@KacieKK

KacieKK commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

@isra-fel Please take a look again

@KacieKK KacieKK requested a review from isra-fel August 2, 2021 18:11
@solankisamir

Copy link
Copy Markdown
Member

@isra-fel can you please take a look at this?

@VeryEarly VeryEarly assigned VeryEarly and unassigned isra-fel Aug 4, 2021
@VeryEarly VeryEarly merged commit dcc2e4b into Azure:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants