[Storage] Upgrade Azure.Storage.Queues to 12.5.0 by blueww · Pull Request #13614 · Azure/azure-powershell

blueww · 2020-11-30T08:53:48Z

Description

Azure.Storage.Queues to 12.5.0 has a new dependency "System.Memory.Data" 1.0.0

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  - {Please put the link here}
- the markdown help files have been regenerated using the commands listed here

msJinLei · 2020-12-01T03:38:52Z

Hi @blueww, there is a signature issue reported.

  D:\a\1\s\artifacts//StaticAnalysisResults\MissingAssemblies.csv:
  "Directory","Assembly Name","Assembly Version","Referencing Assembly","Severity","ProblemId","Description","Remediation"
  "D:\a\1\s\artifacts/Debug\Az.Storage","System.Memory.Data","1.0.0.0","Azure.Storage.Queues","0","3000","Missing assembly System.Memory.Data referenced from Azure.Storage.Queues","Ensure that the assembly is included in the Wix file or directory"

It seems that you need to add it to package reference.

blueww · 2020-12-01T04:19:19Z

@erich-wang
I have added a new dll "System.Memory.Data" to
src/Accounts/Authentication/Utilities/CustomAssemblyResolver.cs
src/lib/NetCorePreloadAssemblies/System.Memory.Data.dll
src/lib/NetFxPreloadAssemblies/System.Memory.Data.dll

But still meet analysis failure. Do I still need to add it to package reference? Is there any sample?

blueww · 2020-12-01T04:19:30Z

/azp run

azure-pipelines · 2020-12-01T04:19:47Z

Azure Pipelines successfully started running 3 pipeline(s).

…ramework. (#12) Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

wyunchi-ms · 2020-12-01T09:02:53Z

/azp run

azure-pipelines · 2020-12-01T09:03:11Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-01T13:45:28Z

/azp run

azure-pipelines · 2020-12-01T13:45:47Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-02T02:21:10Z

/azp run

azure-pipelines · 2020-12-02T02:21:28Z

Azure Pipelines successfully started running 3 pipeline(s).

blueww · 2020-12-02T06:37:21Z

/azp run

azure-pipelines · 2020-12-02T06:37:39Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-02T15:42:55Z

/azp run

azure-pipelines · 2020-12-02T15:43:19Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-03T01:18:24Z

/azp run

azure-pipelines · 2020-12-03T01:18:42Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-07T05:23:40Z

/azp run

azure-pipelines · 2020-12-07T05:23:59Z

Azure Pipelines successfully started running 3 pipeline(s).

blueww · 2020-12-08T06:40:56Z

@wyunchi-ms
Would you please help to see why the test fail?
It seems not related with my change. Let me know if any action I need to take.

The test failed in 2 test cases：

2020-12-07T06:15:19.4780170Z     ! Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.SparkJobTests.TestSynapseSparkJob [1ms]
2020-12-07T06:15:21.3440900Z   [xUnit.net 00:00:11.54]     Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.SqlPoolTests.TestSynapseSqlPoolSecurity [FAIL]
2020-12-07T06:15:22.5422590Z     X Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.SqlPoolTests.TestSynapseSqlPoolSecurity [604ms]
2020-12-07T06:15:22.5427060Z EXEC : error Message:  [/Users/runner/work/1/s/build.proj]
2020-12-07T06:15:22.5429240Z      System.Management.Automation.CommandNotFoundException : The term 'Update-AzSynapseSqlPoolAdvancedThreatProtectionSetting' is not recognized as the name of a cmdlet, function, script file, or operable program.
2020-12-07T06:15:22.5430610Z   Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

2020-12-07T06:15:18.9905890Z   [xUnit.net 00:00:09.20]     Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.WorkspaceTests.TestSynapseWorkspaceSecurity [FAIL]
2020-12-07T06:15:19.0688520Z   [xUnit.net 00:00:09.24]     Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.SparkJobTests.TestSynapseSparkJob [SKIP]
2020-12-07T06:15:19.4281140Z     ! Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.WorkspaceTests.TestSynapseWorkspaceActiveDirectoryAdministrator [1ms]
2020-12-07T06:15:19.4283060Z     X Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.WorkspaceTests.TestSynapseWorkspaceSecurity [946ms]
2020-12-07T06:15:19.4374620Z EXEC : error Message:  [/Users/runner/work/1/s/build.proj]
2020-12-07T06:15:19.4377220Z      System.Management.Automation.CommandNotFoundException : The term 'Enable-AzSynapseSqlAdvancedDataSecurity' is not recognized as the name of a cmdlet, function, script file, or operable program.
2020-12-07T06:15:19.4379090Z   Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

wyunchi-ms · 2020-12-08T09:33:33Z

/azp run

azure-pipelines · 2020-12-08T09:33:54Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-09T04:04:21Z

/azp run

azure-pipelines · 2020-12-09T04:04:39Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-09T07:24:37Z

/azp run

azure-pipelines · 2020-12-09T07:24:56Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-09T12:45:05Z

/azp run

azure-pipelines · 2020-12-09T12:45:23Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-10T02:20:33Z

/azp run

azure-pipelines · 2020-12-10T02:20:50Z

Azure Pipelines successfully started running 3 pipeline(s).

[Storage] Upgrade Azure.Storage.Queues to 12.5.0

84fe479

blueww added the needs-review label Nov 30, 2020

msJinLei added needs-revision and removed needs-review labels Dec 1, 2020

msJinLei assigned blueww Dec 1, 2020

Fix the issue that StaticAnalysis fails to check dependence on .Net f…

1aea240

…ramework. (#12) Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

wyunchi-ms self-assigned this Dec 1, 2020

wyunchi-ms approved these changes Dec 10, 2020

View reviewed changes

wyunchi-ms merged commit a5d00a0 into Azure:master Dec 10, 2020

Conversation

blueww commented Nov 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

msJinLei commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueww commented Dec 1, 2020

Uh oh!

blueww commented Dec 1, 2020

Uh oh!

azure-pipelines Bot commented Dec 1, 2020

Uh oh!

wyunchi-ms commented Dec 1, 2020

Uh oh!

azure-pipelines Bot commented Dec 1, 2020

Uh oh!

wyunchi-ms commented Dec 1, 2020

Uh oh!

azure-pipelines Bot commented Dec 1, 2020

Uh oh!

wyunchi-ms commented Dec 2, 2020

Uh oh!

azure-pipelines Bot commented Dec 2, 2020

Uh oh!

blueww commented Dec 2, 2020

Uh oh!

azure-pipelines Bot commented Dec 2, 2020

Uh oh!

wyunchi-ms commented Dec 2, 2020

Uh oh!

azure-pipelines Bot commented Dec 2, 2020

Uh oh!

wyunchi-ms commented Dec 3, 2020

Uh oh!

azure-pipelines Bot commented Dec 3, 2020

Uh oh!

wyunchi-ms commented Dec 7, 2020

Uh oh!

azure-pipelines Bot commented Dec 7, 2020

Uh oh!

blueww commented Dec 8, 2020

Uh oh!

wyunchi-ms commented Dec 8, 2020

Uh oh!

azure-pipelines Bot commented Dec 8, 2020

Uh oh!

wyunchi-ms commented Dec 9, 2020

Uh oh!

azure-pipelines Bot commented Dec 9, 2020

Uh oh!

wyunchi-ms commented Dec 9, 2020

Uh oh!

azure-pipelines Bot commented Dec 9, 2020

Uh oh!

wyunchi-ms commented Dec 9, 2020

Uh oh!

azure-pipelines Bot commented Dec 9, 2020

Uh oh!

wyunchi-ms commented Dec 10, 2020

Uh oh!

azure-pipelines Bot commented Dec 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blueww commented Nov 30, 2020 •

edited

Loading

msJinLei commented Dec 1, 2020 •

edited

Loading