Skip to content

[engsys] Update CODEOWNERS - #9294

Merged
richardpark-msft merged 1 commit into
Azure:mainfrom
richardpark-msft:azd-add-myself-to-codeowners
Jul 28, 2026
Merged

[engsys] Update CODEOWNERS#9294
richardpark-msft merged 1 commit into
Azure:mainfrom
richardpark-msft:azd-add-myself-to-codeowners

Conversation

@richardpark-msft

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 24, 2026 16:46
@richardpark-msft
richardpark-msft requested a review from a team as a code owner July 24, 2026 16:46
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
22 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds @richardpark-msft as a CODEOWNER for the CODEOWNERS file itself.

Changes:

  • Extends the specific CODEOWNERS rule with the additional owner.
Show a summary per file
File Description
.github/CODEOWNERS Adds the new owner to the file-specific rule.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Medium

@jongio jongio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR Governance check is failing: this PR isn't linked to an issue. Because it's a fork PR, the governance bot can't post its usual reminder here, so noting it manually.

To clear the check, add a closing reference like Fixes #<issue> to the PR description, or link an issue from the sidebar. If this engsys change doesn't warrant an issue, applying the skip-governance label bypasses the check.

@richardpark-msft richardpark-msft added the skip-governance Skip PR governance checks label Jul 24, 2026

@jongio jongio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the existing /.github/ and /eng/ rules that already list you. Since CODEOWNERS is last-match-wins, the more specific /.github/CODEOWNERS line was overriding those and leaving you off as an owner of this file, so adding you here keeps it consistent.

@jongio jongio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things.

The red PR Governance check is stale rather than a real failure. The skip-governance label does work, but the run reporting the failure never saw it:

  • 22:03:17 skip-governance label added
  • 22:03:19 fresh labeled run queued (30129761082)
  • 22:03:27 attempt 3 of the original opened run starts (30110377850)
  • 22:03:29 the fresh run is cancelled by the cancel-in-progress concurrency group
  • 22:04:08 attempt 3 fails with "PR must be linked to a GitHub issue"

pr-governance-issue-check.js reads labels off context.payload.pull_request, and re-running a workflow replays the original event payload. Attempt 3 replayed the opened payload from 16:46, which predates the label, so the skip branch never ran. Removing and re-adding the label queues a fresh run that carries the label, which should clear the check. A new push does the same.

Second, correcting something I said earlier: the /.github/ and /eng/ rules list @danieljurek @vhvb1989 @tg-msft @RickWinter and don't include you. What already covers you is the root /** catch-all, which those more specific rules override. So after this merges you'll own .github/CODEOWNERS but still won't be an owner for anything else under /.github/ or /eng/. Is that the scope you want, or did you mean to be added to those two rules as well?

@jongio jongio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting my last comment: I said the /.github/ and /eng/ rules don't list you. That's wrong. Both already include @richardpark-msft (added in #9214 on July 20), and they're present at this PR's base commit d59fcf8. So disregard my question about whether you meant to be added to those two rules. No follow-up needed there, and the scope of this PR is right as it stands.

@RickWinter RickWinter changed the title [engsys] Adding myself as an owner for CODEOWNERS as well [engsys] Update CODEOWNERS as well Jul 28, 2026
@RickWinter RickWinter changed the title [engsys] Update CODEOWNERS as well [engsys] Update CODEOWNERS Jul 28, 2026
@richardpark-msft

Copy link
Copy Markdown
Member Author

/check-enforcer override

@richardpark-msft
richardpark-msft merged commit 14c242e into Azure:main Jul 28, 2026
8 of 14 checks passed
@richardpark-msft
richardpark-msft deleted the azd-add-myself-to-codeowners branch July 28, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-governance Skip PR governance checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants