[engsys] Update CODEOWNERS - #9294
Conversation
|
Azure Pipelines: 22 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Adds @richardpark-msft as a CODEOWNER for the CODEOWNERS file itself.
Changes:
- Extends the specific CODEOWNERS rule with the additional owner.
Show a summary per file
| File | Description |
|---|---|
.github/CODEOWNERS |
Adds the new owner to the file-specific rule. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
jongio
left a comment
There was a problem hiding this comment.
The PR Governance check is failing: this PR isn't linked to an issue. Because it's a fork PR, the governance bot can't post its usual reminder here, so noting it manually.
To clear the check, add a closing reference like Fixes #<issue> to the PR description, or link an issue from the sidebar. If this engsys change doesn't warrant an issue, applying the skip-governance label bypasses the check.
jongio
left a comment
There was a problem hiding this comment.
This matches the existing /.github/ and /eng/ rules that already list you. Since CODEOWNERS is last-match-wins, the more specific /.github/CODEOWNERS line was overriding those and leaving you off as an owner of this file, so adding you here keeps it consistent.
jongio
left a comment
There was a problem hiding this comment.
Two things.
The red PR Governance check is stale rather than a real failure. The skip-governance label does work, but the run reporting the failure never saw it:
- 22:03:17
skip-governancelabel added - 22:03:19 fresh
labeledrun queued (30129761082) - 22:03:27 attempt 3 of the original
openedrun starts (30110377850) - 22:03:29 the fresh run is cancelled by the
cancel-in-progressconcurrency group - 22:04:08 attempt 3 fails with "PR must be linked to a GitHub issue"
pr-governance-issue-check.js reads labels off context.payload.pull_request, and re-running a workflow replays the original event payload. Attempt 3 replayed the opened payload from 16:46, which predates the label, so the skip branch never ran. Removing and re-adding the label queues a fresh run that carries the label, which should clear the check. A new push does the same.
Second, correcting something I said earlier: the /.github/ and /eng/ rules list @danieljurek @vhvb1989 @tg-msft @RickWinter and don't include you. What already covers you is the root /** catch-all, which those more specific rules override. So after this merges you'll own .github/CODEOWNERS but still won't be an owner for anything else under /.github/ or /eng/. Is that the scope you want, or did you mean to be added to those two rules as well?
jongio
left a comment
There was a problem hiding this comment.
Correcting my last comment: I said the /.github/ and /eng/ rules don't list you. That's wrong. Both already include @richardpark-msft (added in #9214 on July 20), and they're present at this PR's base commit d59fcf8. So disregard my question about whether you meant to be added to those two rules. No follow-up needed there, and the scope of this PR is right as it stands.
|
/check-enforcer override |
No description provided.