Split azd core and extension cspell checks - #7572
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/Azure/azure-dev/sessions/48cd4e9a-98d5-4ba0-b256-262b888e6cfe Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update cspell check to handle core and extension files separately
Split azd core and extension cspell checks
Apr 8, 2026
Agent-Logs-Url: https://github.com/Azure/azure-dev/sessions/c7a413b3-e44a-45fc-b0db-0179c3cc54b0 Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
…l.yaml changes Agent-Logs-Url: https://github.com/Azure/azure-dev/sessions/c7a413b3-e44a-45fc-b0db-0179c3cc54b0 Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Jon Gallant (jongio)
approved these changes
Apr 8, 2026
Jon Gallant (jongio)
left a comment
Jon Gallant (jongio)
left a comment
Member
There was a problem hiding this comment.
Clean PR. Checked override migration paths, cspell config cascade with import, workflow trigger/exclusion patterns, and extension completeness - nothing to flag.
JeffreyCA
marked this pull request as ready for review
April 8, 2026 18:44
JeffreyCA
requested review from
Amit Chauhan (achauhan-scc),
Daniel Jurek (danieljurek),
Marina He (hemarina),
kingernupur,
Radhika B (rabollin),
Rajesh Kamal (rajeshkamal5050),
saanikaguptamicrosoft,
tg-msft,
John Miller (therealjohn),
Travis Angevine (trangevi),
Travis Wilson (trrwilson),
Victor Vazquez (vhvb1989),
Wallace Breza (wbreza) and
Wei Lim (weikanglim)
as code owners
April 8, 2026 18:45
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Splits cspell validation between azd core and extensions by introducing per-extension cspell configs that import the main azd config, and by separating GitHub Actions spellcheck workflows accordingly.
Changes:
- Added/updated per-extension
cspell.yamlfiles toimportthe main azd cspell config and keep extension-specific overrides local. - Removed extension-specific override entries from
cli/azd/.vscode/cspell.yaml. - Added a dedicated
cspell-extworkflow and updatedcli-cispellcheck to exclude extensions.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
cli/azd/extensions/microsoft.azd.extensions/cspell.yaml |
Adds per-extension cspell config importing main config and local overrides. |
cli/azd/extensions/microsoft.azd.demo/cspell.yaml |
Imports main config and moves an override locally while retaining extension words. |
cli/azd/extensions/microsoft.azd.concurx/cspell.yaml |
Adds per-extension cspell config importing main config and local overrides. |
cli/azd/extensions/microsoft.azd.ai.builder/cspell.yaml |
Adds per-extension cspell config importing main config and local overrides. |
cli/azd/extensions/azure.coding-agent/cspell.yaml |
Adds minimal per-extension cspell config importing main config. |
cli/azd/extensions/azure.appservice/cspell.yaml |
Adds minimal per-extension cspell config importing main config. |
cli/azd/extensions/azure.ai.models/cspell.yaml |
Imports main config and moves a file-specific override locally while retaining extension words. |
cli/azd/extensions/azure.ai.finetune/cspell.yaml |
Imports main config while retaining extension words. |
cli/azd/extensions/azure.ai.agents/cspell.yaml |
Imports main config while retaining extension words. |
cli/azd/.vscode/cspell.yaml |
Removes extension-specific overrides now handled in per-extension configs. |
.github/workflows/cspell-ext.yml |
Introduces extension-only cspell workflow. |
.github/workflows/cli-ci.yml |
Excludes extensions from core spellcheck job and runs from cli/azd working directory. |
Contributor
|
/check-enforcer evaluate |
Contributor
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7571
This PR restructures how spell checking is managed for extension code and documentation. It moves extension-specific spelling overrides out of the main configuration and into per-extension
cspell.yamlfiles, and introduces a dedicated GitHub Actions workflow to lint only extension files. This makes the spell check configuration more modular and maintainable.Spell check configuration modularization:
Moved extension-specific spelling overrides from the main
cli/azd/.vscode/cspell.yamlinto individualcspell.yamlfiles for each extension (e.g.,azure.ai.agents,azure.ai.finetune,microsoft.azd.demo, etc.), each importing the shared config and defining their own overrides as needed. [1] [2] [3] [4] [5] [6] [7] [8]Cleaned up the main
cspell.yamlby removing extension-specific overrides, ensuring it only contains project-wide settings. [1] [2] [3]CI workflow improvements:
Updated the main spell check job in
.github/workflows/cli-ci.ymlto exclude extension files and only lint core project files.Added a new workflow
.github/workflows/cspell-ext.ymlthat runs spell checking specifically for extension files and their configs, ensuring per-extensioncspell.yamlfiles are respected.