Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ func runConfigCommand(cmd *cobra.Command, flagValues *flagValues) error {
return fmt.Errorf("failed getting a subscription from prompt. Try logging in manually with 'azd auth login' before running this command %w", err)
}

tenantID := subscriptionResponse.Subscription.TenantId
tenantID := subscriptionResponse.Subscription.UserTenantId
subscriptionID := subscriptionResponse.Subscription.Id
Comment on lines +202 to 203

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we verify other extensions don't have the same issue too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll turn the engines on it :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audited all extensions. Found and fixed the same bug in 5 more:

Extension Files Status
azure.ai.models custom.go, init.go (2 spots) ❌ Fixed
azure.ai.agents init.go, init_from_code.go ❌ Fixed
azure.ai.finetune init.go (2 spots) ❌ Fixed
microsoft.azd.ai.builder start.go ❌ Fixed
microsoft.azd.demo prompt.go ❌ Fixed
azure.appservice swap.go ✅ Already correct (uses LookupTenant)
azure.ai.agents parser.go, service_target_agent.go ✅ Already correct (uses LookupTenant)

Pushed in b5c9ebf.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was me the entire time! :|


cred, err := azidentity.NewAzureDeveloperCLICredential(&azidentity.AzureDeveloperCLICredentialOptions{
Comment thread
vhvb1989 marked this conversation as resolved.
Expand Down
Loading