Skip to content

[auto] instructions: (more copilot code review instructions update) #8930

Description

@github-actions

Proposed by the Update Instructions From PR Reviews workflow.

Settings

Stats

  • Signal ratio: ~25 genuine reviewer asks kept / ~35 dropped (bots, author acks, LGTM, <30 chars)
  • Resolved PRs examined: 27 merged (complete review data for 16; 11 were rate-limited)

PR comment themes

  • Test coverage symmetry — when one prompt path (e.g. subscription) has success/error/cancellation tests, add equivalent tests for the symmetric path (e.g. location); add serialisation round-trip assertions; test compound constraint combinations (step-alignment × max-capacity) — #8883, #8874, #8876

Themes below promotion threshold (shown for visibility)

The following themes each appeared in only 1 PR and did not meet the ≥2 PR / ≥2 reviewer or single-reviewer ≥3 threshold:

  • sort.*slices.SortFunc with cmp.Compare#8879 (already in AGENTS.md; not promoted)
  • url.PathEscape for HTTP path parameters — #8881
  • Use existing helpers over manual flag registration — #8881
  • Keep PR description in sync when commits change scope — #8896

Generated by Update Instructions From PR Reviews · 734.3 AIC · ⌖ 37.8 AIC · ⊞ 36.3K ·


Note

This was originally intended as a pull request, but GitHub Actions is not permitted to create or approve pull requests in this repository.
The changes have been pushed to branch automated/update-instructions-from-pr-reviews.

Click here to create the pull request

To fix the permissions issue, go to SettingsActionsGeneral and enable Allow GitHub Actions to create and approve pull requests. See also: gh-aw FAQ

Show patch preview (44 of 44 lines)
From 30fa879decffb3ba8540e23da9f0dd124e282463 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]" <github-actions[bot]@users.noreply.github.com>
Date: Wed, 1 Jul 2026 20:49:07 +0000
Subject: [PATCH] instructions: add test coverage symmetry rule to Go review
 guidelines
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Adds a new 'Test coverage symmetry' section to go.instructions.md, sourced
from recurring reviewer feedback across three PRs (#8883, #8874, #8876).

Rule covers three patterns flagged by reviewers:
- Symmetric prompt paths (subscription ↔ location: success/error/cancel)
- Serialisation round-trip tests (save + reload, not just write direction)
- Compound constraint interactions (step-alignment × max-capacity)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 .github/instructions/go.instructions.md | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/.github/instructions/go.instructions.md b/.github/instructions/go.instructions.md
index c39dc04..1ff2589 100644
--- a/.github/instructions/go.instructions.md
+++ b/.github/instructions/go.instructions.md
@@ -31,3 +31,13 @@ all existing imports or declarations.
 
 - When reviewing command input resolution, explicit CLI args and flags should win over defaults. Do not prompt the user toward a different default when they provided a valid new value; reserve prompts for ambiguous choices and preserve deterministic `--no-prompt` behavior for CI/scripts.
 - When filtering AI models or quota data by location, keep location-specific usage data associated with only the models available in that location. Empty or unknown usage data from an unrelated location must not make a model eligible elsewhere; add regression coverage for cross-location quota cases.
+
+## Test coverage symmetry
+
+When tests exist for one side of a symmetric code path, flag the missing counterpart:
+
+- **Prompt paths**: If there is a test for subscription prompt (succes
... (truncated)

Metadata

Metadata

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions