Advisor Module Updates#5334
Merged
Merged
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5334 |
tjprescott
suggested changes
Jan 18, 2018
tjprescott
left a comment
tjprescott
left a comment
Member
There was a problem hiding this comment.
Please set up a meeting with us. A quick review of the advisor module gives me concern that the module is not ready for GA (which is separate from the service GA).
| Release History | ||
| =============== | ||
|
|
||
| 1.0.0 |
Member
There was a problem hiding this comment.
If this is a GA release, it should be 2.0.0
Member
- Removed 'recommendation generate' command and added a '--refresh' option to 'recommendation list' instead. - Renamed 'configuration get' to 'configuration list'. - Renamed 'configuration set' to 'configuration update'. - Test recording updates.
tjprescott
reviewed
Jan 23, 2018
|
|
||
| 1.0.0 | ||
| ++++++ | ||
| * GA release. |
Member
There was a problem hiding this comment.
Here you will want to call out whatever breaking changes were made. For example
* BC: `advisor configuration set` renamed to `advisor configuration update`
and so on.
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5334 |
Member
|
The needs to be rebased and missed the code-complete for Sprint 31. Moving to Sprint 32. |
Get latest changes from upstream
Merge with upstream
- Removed 'recommendation generate' command and added a '--refresh' option to 'recommendation list' instead. - Renamed 'configuration get' to 'configuration list'. - Renamed 'configuration set' to 'configuration update'. - Test recording updates.
tjprescott
approved these changes
Feb 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)