[Core] Prefer PowerShell launcher on Windows to preserve multiline CLI arguments#33595
[Core] Prefer PowerShell launcher on Windows to preserve multiline CLI arguments#33595Copilot wants to merge 6 commits into
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @copilot, |
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
jsntcy,
wangzelin007 and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
Live test results —
|
|
Core |
azclibot
left a comment
azclibot
left a comment
There was a problem hiding this comment.
❌ CI and Live-Test Review
@copilot, the automated checks for this PR have completed with failures. Please investigate and address the following issues.
CI Check Failures (3 failed / 91 passed)
| Check | Result | Link |
|---|---|---|
| Azure.azure-cli (build) | ❌ failure | Build #20260622.3 failed |
| Azure.azure-cli (Credential Scanner) | ❌ failure | Credential Scanner failed |
| Azure.azure-cli (Codegen Coverage) | ❌ failure | Codegen Coverage failed |
Live Test Result
| Workflow | Result | Link |
|---|---|---|
| Live integration test | ❌ failure | Run #27923808753 |
Next Steps
- Review the build failure log to identify compilation or packaging errors.
- Investigate the Credential Scanner failure — ensure no secrets or credentials were accidentally included.
- Check the Codegen Coverage failure — verify the code generation coverage meets required thresholds.
- Review the live test failure for runtime errors against the actual Azure service.
Once the issues are resolved and a new commit is pushed, the checks will be re-evaluated.
Posted by agent-assist (autonomous bug-fix pipeline).
|
@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33595 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
Addressed and pushed fixes in |
Live test results —
|
Live test results —
|
azclibot
left a comment
azclibot
left a comment
There was a problem hiding this comment.
❌ Issues Found
Some checks or the live test failed. Please investigate and fix.
Posted by agent-assist (autonomous bug-fix pipeline).
|
@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33595 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
I investigated the failures via workflow logs.
There isn’t a safe code fix inside this PR for those two failures. Please either rerun live test with an explicit target module input (or skip live test for packaging-only PRs), and handle the cred-scan baseline/suppression in the upstream appservice change. |
Related command
`az repos pr create --description "First paragraph
Second paragraph"`
Description
Windows
az.cmdforwarding (%*) drops content after embedded newlines. This PR makes packaged Windows installs expose and exercise a PowerShell launcher path (az.ps1) so multiline arguments are preserved when invoked from PowerShell.build_scripts/windows/scripts/build.cmdnow packagesaz.ps1into MSI layout:wbin\az.ps1(frombuild_scripts/windows/scripts/az.ps1)build_scripts/windows/scripts/build.cmdnow packagesaz.ps1into ZIP layout:bin\az.ps1(frombuild_scripts/windows/scripts/az_zip.ps1)build_scripts/windows/scripts/az.ps1(AZ_INSTALLER="MSI")build_scripts/windows/scripts/az_zip.ps1(AZ_INSTALLER="ZIP")python.exelocation.build_scripts/windows/scripts/test_msi_installation.ps1now invokes...\wbin\az.ps1build_scripts/windows/scripts/test_zip_installation.ps1now invokes...\bin\az.ps1az.cmdargument forwarding for install validation and packaged launcher availability.AZ_INSTALLERis preserved correctly per package type for the PowerShell launcher path (MSI vs ZIP).Testing Guide
Use a multiline argument from PowerShell against the packaged launcher path (MSI
wbin\az.ps1or ZIPbin\az.ps1), e.g.--descriptionwith embedded newlines, and confirm full value reaches CLI parsing.Also verify installer marker behavior through the PowerShell launchers:
AZ_INSTALLER=MSIAZ_INSTALLER=ZIPHistory Notes
[Core]
az: Package dedicatedaz.ps1launchers for Windows MSI/ZIP layouts and useaz.ps1in install validation to avoid multiline argument truncation viaaz.cmdin PowerShell.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.