{CI} Fix homebrew formula test by stripping no_autobump! in local tap#33540
Merged
YangAn-microsoft merged 1 commit intoJun 15, 2026
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Test Homebrew Formula CI job failure caused by upstream changes to the homebrew-core azure-cli formula: the upstream formula now includes no_autobump!, which newer Homebrew versions only allow in official taps. Since the CI installs the generated formula via a local dummy tap (dev/azure-cli), Homebrew rejects it unless that directive is removed in the local-tap copy.
Changes:
- Strip the
no_autobump!line from the formula only after it’s copied into the local dummy tap used by CI. - Leave the generated/released formula artifact unchanged so the directive remains present for submission to the official
homebrew-coretap.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
CI |
naga-nandyala
approved these changes
Jun 14, 2026
naga-nandyala
left a comment
naga-nandyala
left a comment
Contributor
There was a problem hiding this comment.
LGTM
No risk as we are only removing this from the internal test step on CI and not from actual formula.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Test Homebrew FormulaCI job started failing with:Root cause
The formula generator (
scripts/release/homebrew/docker/formula_generate.py) buildsazure-cli.rbby downloading the latest upstreamhomebrew-coreformula and patching it (version/url/sha/deps). The upstream formula now contains:no_autobump!tells Homebrew''s autobump bot not to auto-bump azure-cli (the Azure CLI team submits full updates itself, since each release also needs the entire dependencyresourcelist regenerated).This line had been carried into our generated formula harmlessly for a while. The failure was triggered by an external Homebrew change, not by any recent commit in this repo:
Homebrew/brew#21982 — "cask: restrict
no_autobump!usage to official Homebrew taps" — merged 2026-04-21 (commitb72c12f). It added a guard toformula.rb/cask/dsl.rb:Before this PR,
no_autobump!was accepted in any tap (it resolved a long-standing TODO). After the CI image picked up a Homebrew version containing it, the previously-tolerated directive started raising an error.Our CI test installs the generated formula into a local dummy tap (
dev/azure-cli), which is not official, so Homebrew now rejects it.Fix
Strip the
no_autobump!line only from the test copy placed in the local dev tap, right beforebrew install. The directive must remain in the released formula (which is submitted to the officialhomebrew-coretap), so the generator and the published artifact are left untouched. If upstream later removes the line, thesedbecomes a harmless no-op.