-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{Pylint} Fix implicit-str-concat #30363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3acb6c1
ff5cd94
1d93ab8
aa90370
48dc035
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -292,7 +292,7 @@ def create_action(action_name, cache_behavior=None, cache_duration=None, header_ | |
| action = { | ||
| "cache_key_query_string": { | ||
| "parameters": { | ||
| "type_name" "DeliveryRuleCacheKeyQueryStringBehaviorActionParameters" | ||
| "type_name": "DeliveryRuleCacheKeyQueryStringBehaviorActionParameters", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't imagine how the code still works while it is as wrong as such. |
||
| "query_string_behavior": query_string_behavior, | ||
| "query_parameters": query_parameters | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -42,17 +42,17 @@ def load_arguments(self, _): | |||||
| 'namespace', | ||||||
| completer=get_providers_completion_list, | ||||||
| arg_group='Resource ID', | ||||||
| help='Provider namespace (Ex: ''Microsoft.Provider'').') | ||||||
| help='Provider namespace (Ex: Microsoft.Provider).') | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the author actually wants to quote
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the following three help messages be kept consistent? Personally, I think when parentheses are used, having or not having double quotes is fine. |
||||||
| c.argument( | ||||||
| 'resource_type_parent', | ||||||
| options_list=['--parent'], | ||||||
| arg_group='Resource ID', | ||||||
| help='The parent path (Ex: ''resourceTypeA/nameA/resourceTypeB/nameB'').') | ||||||
| help='The parent path (Ex: resourceTypeA/nameA/resourceTypeB/nameB).') | ||||||
| c.argument( | ||||||
| 'resource_type', | ||||||
| completer=get_resource_types_completion_list, | ||||||
| arg_group='Resource ID', | ||||||
| help='Resource type (Ex: ''resourceTypeC'').') | ||||||
| help='Resource type (Ex: resourceTypeC).') | ||||||
|
|
||||||
| for scope in ['state', 'event']: | ||||||
| with self.argument_context('policy {}'.format(scope)) as c: | ||||||
|
|
@@ -137,7 +137,7 @@ def load_arguments(self, _): | |||||
| 'location_filters', | ||||||
| options_list='--location-filters', | ||||||
| nargs='+', | ||||||
| help='Space separated list of resource locations that should be remediated (Ex: ''centralus westeurope'').') # pylint: disable=line-too-long | ||||||
| help='Space separated list of resource locations that should be remediated (Ex: centralus westeurope).') # pylint: disable=line-too-long | ||||||
| c.argument( | ||||||
| 'policy_assignment', | ||||||
| options_list=['--policy-assignment', '-a'], | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the author wants to quote
Gi: