Skip to content

[AMS] Removing deprecated variable 'identifier_uri' from create sp method #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Nov 16, 2021
Merged

[AMS] Removing deprecated variable 'identifier_uri' from create sp method #20281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/azure-cli/azure/cli/command_modules/ams/operations/sp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def reset_sp_credentials_for_mediaservice(cmd, client, account_name, resource_gr

graph_client = _graph_client_factory(cmd.cli_ctx)

sp_name = _create_sp_name(account_name, sp_name)
sp_name = _create_sp_name(account_name, sp_name) if sp_name is None else sp_name
sp_password = _create_sp_password(sp_password)

app_display_name = sp_name.replace('http://', '')
Expand Down Expand Up @@ -86,7 +86,6 @@ def create_or_update_assign_sp_to_mediaservice(cmd, client, account_name, resour
homepage=sp_name,
years=years,
password=sp_password,
identifier_uris=[sp_name],
available_to_other_tenants=False)

app_id = aad_application.app_id
Expand Down Expand Up @@ -279,13 +278,13 @@ def _create_service_principal(
return aad_sp.object_id


def create_application(client, display_name, homepage, years, password, identifier_uris,
def create_application(client, display_name, homepage, years, password,
available_to_other_tenants=False, reply_urls=None):
password_credential = _build_password_credential(password, years)

app_create_param = ApplicationCreateParameters(available_to_other_tenants=available_to_other_tenants,
display_name=display_name,
identifier_uris=identifier_uris,
identifier_uris=[],
homepage=homepage,
reply_urls=reply_urls,
password_credentials=[password_credential])
Expand Down
Loading