Skip to content

[AMS] Removing deprecated variable 'identifier_uri' from create sp method #20249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hivyas wants to merge 26 commits into from
Closed

[AMS] Removing deprecated variable 'identifier_uri' from create sp method #20249

Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
1c998bd
reverting changes for ASK key
hivyas Mar 16, 2020
67c7e04
reverting changes
hivyas Mar 16, 2020
44e755f
updated ams module to dec 2019 swagger
hivyas Apr 24, 2020
dc0e466
added test cases
hivyas Apr 28, 2020
eaf7f59
added ability to update offlinerental
hivyas Apr 29, 2020
0885ea9
fixed audio language bug
hivyas Apr 30, 2020
6fbab37
Merge branch 'dev' into dev
hivyas May 1, 2020
2cd98d7
fixing requirements*.txt files
hivyas May 7, 2020
3b31409
Fixed transforms test case and national bug
hivyas May 7, 2020
b398868
updated content key policy tests
hivyas May 8, 2020
12fbf09
fixed style and lint errors
hivyas May 8, 2020
20c3944
Merge remote-tracking branch 'upstream/dev' into dev
hivyas Jun 11, 2020
91528ee
made az ams sp create idempotent
hivyas Jul 20, 2020
9297770
fixed typo and updated help text
hivyas Jul 21, 2020
d0e7756
Merge remote-tracking branch 'upstream/dev' into dev
hivyas Aug 11, 2020
c46c527
Merge remote-tracking branch 'upstream/dev' into dev
hivyas Sep 22, 2020
b70c052
Merge remote-tracking branch 'upstream/dev' into dev
hivyas Oct 26, 2020
b393193
Merge remote-tracking branch 'upstream/dev' into dev
hivyas Nov 18, 2020
56ffb7e
Merge branch 'dev' of https://github.com/Azure/azure-cli into dev
hivyas Jun 9, 2021
bcd0727
Merge remote-tracking branch 'upstream/dev' into dev
hivyas Jul 28, 2021
1950fe3
Merge branch 'dev' of https://github.com/Azure/azure-cli into dev
hivyas Aug 13, 2021
87b6066
Merge branch 'dev' of https://github.com/Azure/azure-cli into dev
hivyas Sep 23, 2021
fc558d2
Merge remote-tracking branch 'upstream/main' into dev
hivyas Nov 3, 2021
7485ed0
Merge branch 'dev' of https://github.com/Azure/azure-cli into dev
hivyas Nov 3, 2021
407745b
Merge branch 'dev' of https://github.com/Azure/azure-cli into dev
hivyas Nov 9, 2021
c6ee439
removing deprecated variable
hivyas Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/azure-cli/azure/cli/command_modules/ams/operations/sp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ def create_or_update_assign_sp_to_mediaservice(cmd, client, account_name, resour
homepage=sp_name,
years=years,
password=sp_password,
identifier_uris=[sp_name],
available_to_other_tenants=False)

app_id = aad_application.app_id
Expand Down Expand Up @@ -279,13 +278,12 @@ def _create_service_principal(
return aad_sp.object_id


def create_application(client, display_name, homepage, years, password, identifier_uris,
def create_application(client, display_name, homepage, years, password,
available_to_other_tenants=False, reply_urls=None):
password_credential = _build_password_credential(password, years)

app_create_param = ApplicationCreateParameters(available_to_other_tenants=available_to_other_tenants,
display_name=display_name,
identifier_uris=identifier_uris,
homepage=homepage,
reply_urls=reply_urls,
password_credentials=[password_credential])
Expand Down