Skip to content

{Core} Refine error message for MSAL token cache absence #19900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 2 commits into from
Oct 21, 2021
Merged

{Core} Refine error message for MSAL token cache absence #19900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c3c683
Update
jiasli Oct 21, 2021
b878d37
Remove 'please'
jiasli Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/auth/identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def load_entry(self, sp_id, tenant):
matched = [x for x in self._entries if sp_id == x[_CLIENT_ID]]
if not matched:
raise CLIError("Could not retrieve credential from local cache for service principal {}. "
"Please run `az login` for this service principal."
"Run `az login` for this service principal."
.format(sp_id))
matched_with_tenant = [x for x in matched if tenant == x[_TENANT]]
if matched_with_tenant:
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/auth/msal_authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def __init__(self, client_id, username, **kwargs):
accounts = self.get_accounts(username)

if not accounts:
raise CLIError("User {} does not exist in the MSAL token cache. Please run `az login`.".format(username))
raise CLIError("User {} does not exist in MSAL token cache. Run `az login`.".format(username))

if len(accounts) > 1:
raise CLIError("Found multiple accounts with the same username. Please report to us via Github: "
Expand Down