Fix #1123: Update az network dns zone update#1300
Merged
Merged
Conversation
tjprescott
suggested changes
Nov 11, 2016
tjprescott
left a comment
tjprescott
left a comment
Member
There was a problem hiding this comment.
This PR doesn't work properly with the generic update flow. There's guidance on generic update here:
https://github.com/Azure/azure-cli/blob/master/doc/authoring_command_modules/authoring_commands.md
but don't hesitate to come grab me.
Member
There was a problem hiding this comment.
You could probably leave off the talk about '*' since if you omit --if-match you would expect it to match any (or just ignore it entirely).
tjprescott
reviewed
Nov 11, 2016
Member
There was a problem hiding this comment.
After our discussion, you should use the create_or_update from the SDK as the setter. You don't need a custom setter.
You just need to register an alias:
register_cli_argument('network dns zone update', 'if_none_match', ignore_type)
tjprescott
approved these changes
Nov 11, 2016
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to resolve #1123