Remove ad-hoc api versions

[jiasli]

Several command modules use ad-hoc api versions for azure-mgmt-network SDK (#17816):

azure-cli/src/azure-cli-core/azure/cli/core/profiles/_shared.py

Lines 406 to 416 in 3e26929

	# We should avoid using ad hoc API versions,
	# use the version in a profile as much as possible.
	AD_HOC_API_VERSIONS = {
	ResourceType.MGMT_NETWORK: {
	'vm_default_target_network': '2018-01-01',
	'nw_connection_monitor': '2019-06-01',
	'container_network': '2018-08-01',
	'appservice_network': '2020-04-01',
	'appservice_ensure_subnet': '2019-02-01'
	}
	}

These API versions are preserved when trimming the azure-mgmt-network SDK:

azure-cli/build_scripts/windows/scripts/remove_unused_api_versions.py

Lines 18 to 20 in fcbce97

	def remove_unused_network_api_versions():
	# Hard-coded API versions
	used_network_api_versions = set(AD_HOC_API_VERSIONS[ResourceType.MGMT_NETWORK].values())

This leads to bigger Azure CLI package.

The solution is to migrate to the latest API version:

azure-cli/src/azure-cli-core/azure/cli/core/profiles/_shared.py

Line 155 in 3e26929

ResourceType.MGMT_NETWORK: '2021-08-01',

[jiasli]

vm_default_target_network: @zhoxing-ms
nw_connection_monitor: @necusjz
container_network: @joseph-porter
appservice_network, appservice_ensure_subnet: @panchagnula

[zhoxing-ms]

'vm_default_target_network': '2018-01-01'

The reference of Compute module to vm_default_target_network is mainly divided into two cases:

1. ARM template deployment
   • build_public_ip_resource
   • build_load_balancer_resource

In this case, Python SDK will not be used, so it will not affect the reduction of SDK package size.
In order to ensure the feature stability and keep consistent with the api-version settings of other resources, we will continue to hard code an independent api-version for this case.

2. Get network client
   • _validate_vm_vmss_create_vnet
   • _get_default_address_pool
   • _validate_vmss_create_load_balancer_or_app_gateway
   • get_network_lb
   • get_vm_details

This case will lead to unnecessary Python SDK version dependency. The reason for the previous design was to avoid excessive re-recording of the yaml files of Compute module when bumping the api-version for network RP:

azure-cli/src/azure-cli/azure/cli/command_modules/vm/_vm_utils.py

Lines 25 to 29 in 34fe389

	def get_target_network_api(cli_ctx):
	""" Since most compute calls don't need advanced network functionality, we can target a supported, but not
	necessarily latest, network API version is order to avoid having to re-record every test that uses VM create
	(which there are a lot) whenever NRP bumps their API version (which is often)!
	"""

But fortunately, we now have the bumping version pipeline to help solve this problem, so they can be modified to use the api-version of Network module. @necusjz Please be aware~

[panchagnula]

appservice_ensure_subnet

@madsd before I make the changes to use the latest version / default-version, wanted to check if there is a reason we use an ADhoc version for ASE & access-restrictions on App Service? Can these be safely removed?

[madsd]

@panchagnula as I recall, this was to force to a newer API when this was developed as the "default" did not support delegations. This should not be a problem now.

[panchagnula]

@panchagnula as I recall, this was to force to a newer API when this was developed as the "default" did not support delegations. This should not be a problem now.

Thanks for reviewing & sign-off on PR as well @madsd

[necusjz]

Let's remove them in the coming breaking change window.