Skip to content

[Serial-Console] Fix pair mapping region for eastus to westus - #6231

Merged
kai ru (kairu-ms) merged 12 commits into
Azure:mainfrom
rhkodiak:main
Jun 1, 2023
Merged

kai ru (kairu-ms) merged 12 commits into
Azure:mainfrom
rhkodiak:main

Conversation

@rhkodiak

@rhkodiak Richard Hoover (rhkodiak) commented Apr 21, 2023 •

Copy link
Copy Markdown
Contributor

The changes in the pull request are to address a problem found in the azure cli serial-console extension where an error was being thrown for eastus connections because there wasn't a pair region mapping for westus. The code changes add the eastus to westus region mappings to fix this issue.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az serial-console connect -g MyResourceGroup -n MyVmName

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Richard Hoover (@rhkodiak),
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 21, 2023
@ghost

Copy link
Copy Markdown

Thank you for your contribution rhkodiak! We will review the pull request and get back to you soon.

@yonzhan

Copy link
Copy Markdown
Collaborator

Serial-Console

@msftvito

msftvito commented May 4, 2023

Copy link
Copy Markdown

Can this be looked at?

@yonzhan

Copy link
Copy Markdown
Collaborator

Please fix CI issues first.

@msftvito

msftvito commented May 5, 2023

Copy link
Copy Markdown

Richard Hoover (@rhkodiak) there's other changes mixed in with the one for my issue. Can you resolve the issues so the PR goes through?

@kairu-ms

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kairu-ms kai ru (kairu-ms) changed the title [Serial-Console]: Fix pair mapping region for eastus to westus [Serial-Console] Fix pair mapping region for eastus to westus May 5, 2023
@kairu-ms

Copy link
Copy Markdown
Contributor

Hi Richard Hoover (@rhkodiak) You may need to record the failed tests again.

@msftvito

Copy link
Copy Markdown

Richard Hoover (@rhkodiak) are you able to resolve the failing tests?

@rhkodiak

Richard Hoover (rhkodiak) commented May 16, 2023 •

Copy link
Copy Markdown
Contributor Author

Richard Hoover (@rhkodiak) are you able to resolve the failing tests?

msftvito - Yes, I will resolve this today.

@msftvito

Copy link
Copy Markdown

@rhkodiak

Richard Hoover (rhkodiak) commented May 25, 2023 •

Copy link
Copy Markdown
Contributor Author

Richard Hoover (@rhkodiak) it seems like the last build also had some errors? https://github.com/Azure/azure-cli-extensions/pull/6231/checks?check_run_id=13531660777

msftvito - when I run the "azdev test serial-console --live" command to record the new test results the command completes successfully for me. I look at the build log where the failure occurs but I don't see why it fails here and not when I locally run the live tests. Can you run the command and see if you get the same results?

image

@kairu-ms

Copy link
Copy Markdown
Contributor

Hi Richard Hoover (@rhkodiak), according to the CI result, it seems the azure-mgmt-resource sdk is not the latest in your Local machine. Please pull the latest change of dev branch of azure-cli repo and run azdev setup again to update the sdks. After that you can record the tests again.

@rhkodiak

Copy link
Copy Markdown
Contributor Author

Hi Richard Hoover (@rhkodiak), according to the CI result, it seems the azure-mgmt-resource sdk is not the latest in your Local machine. Please pull the latest change of dev branch of azure-cli repo and run azdev setup again to update the sdks. After that you can record the tests again.

Hi kai ru (@kairu-ms), I ran the instructions you provided and everything looks good now so ready for you to review. Thanks for the help!

@kairu-ms
kai ru (kairu-ms) merged commit eacae60 into Azure:main Jun 1, 2023
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ serial-console ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=59480&view=results

@msftvito

msftvito commented Jun 1, 2023

Copy link
Copy Markdown

Thank you everyone for getting this merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Serial Console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants