Repository navigation
{AKS} Add transform function for custom CA - #5575
Merged
Xing Zhou (zhoxing-ms) merged 3 commits intoNov 25, 2022
Merged
Conversation
ghost
requested review from
ZelinWang (wangzelin007) and
Xing Zhou (zhoxing-ms)
November 24, 2022 07:42
ghost
assigned
ghost
requested a review
from Yong Zhang (yonzhan)
November 24, 2022 07:43
1 of 3 tasks
FumingZhang
marked this pull request as ready for review
November 24, 2022 08:01
FumingZhang
requested a review
from Liming Liu (andyliuliming)
as a code owner
November 24, 2022 08:01
Collaborator
|
AKS |
FumingZhang
force-pushed
the
fuming/add-transform-1124
branch
from
November 25, 2022 08:29
5fb0501 to
3a7d626
Compare
Xing Zhou (zhoxing-ms)
approved these changes
Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Add custom transform function to handle type conversion for custom CA. Currently this feature is only in preview API. Before feature GA, also need to add this transform to azure-cli/acs.
Related command
aks xxxGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.