Repository navigation
[connectedvmware] Bump up api version, add vm retain support - #5556
Merged
Xing Zhou (zhoxing-ms) merged 3 commits intoNov 24, 2022
Merged
Xing Zhou (zhoxing-ms) merged 3 commits into
Xing Zhou (zhoxing-ms) merged 3 commits into
Conversation
ghost
added
the 
Collaborator
|
connectedvmware |
Sayan Naskar (nascarsayan)
marked this pull request as ready for review
November 20, 2022 08:02
Contributor
|
Could you add new tests for this new parameter? |
Contributor
|
Do you want to release a new extension version for this PR change? If so, please add the description of the new parameter into the |
Contributor
Author
Xing Zhou (@zhoxing-ms) , Have added tests for the new parameter. Also, have increased the extension build number. |
Xing Zhou (zhoxing-ms)
approved these changes
Nov 24, 2022
Collaborator
|
[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=16816&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping up the API version from 2020-10-01-preview to 2022-01-10-preview, as we need access to the retain query parameter for VM delete in the az subcommand.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.