Repository navigation
[Container App]: Remove quota check for 'az containerapps env create' - #5548
Xing Zhou (zhoxing-ms) merged 9 commits into
Conversation
ghost
added
the 
Zijian-Ju
changed the title
Zijian-Ju
changed the title
Zijian-Ju
changed the title
|
Container App |
|
This will break |
There was a problem hiding this comment.
Please leave validate_environment_location as-is and simply remove the call of validate_managed_environment from create_managed_environment. containerapp up auto creates environments and therefore needs to ensure the environment is created so it must be sure there is available quota on region using validate_environment_logic. Removing this would result in a worse customer experience.
|
|
|
Zijian-Ju Do you want to release a new extension version for this PR change? If so, please write the description of PR change into the |
|
Currently we do allow our customers to create more than 5 managed environments in a region after they submitted a quota request. Otherwise we restrict some of the customers to create less than 5 environments according to their subscription offer type. In this case, will it still block customers to create environment using 'az container up' when they are allowed to create more? |
| return location | ||
| else: | ||
| raise ValidationError("You cannot create any more environments. Environments are limited to {} per location in a subscription. Please specify an existing environment using --environment.".format(MAX_ENV_PER_LOCATION)) | ||
| return res_locations[0] |
There was a problem hiding this comment.
add null check
There was a problem hiding this comment.
res_location will not be empty after the change as we don't filter by remaining quota anymore
|
Hi Xing Zhou (@zhoxing-ms), could you please help merge this PR and make a new release? The customer is urgently waiting the fix. Thank you |
|
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=16319&view=results |
7 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.