Repository navigation
Update diagnostics commands to work with clusters with local accounts disabled - #5539
Merged
Xing Zhou (zhoxing-ms) merged 10 commits intoNov 24, 2022
Merged
Conversation
Collaborator
|
AKS |
Yong Zhang (yonzhan)
requested review from
Julie Zhu (yanzhudd) and
Xing Zhou (zhoxing-ms)
November 10, 2022 23:00
FumingZhang
reviewed
Nov 11, 2022
FumingZhang
left a comment
FumingZhang
left a comment
Member
There was a problem hiding this comment.
The PR looks good to me, but I suppose it would be better if you could write a live test case to test the whole process.
… accounts disabled
…l accounts disabled
peterbom
force-pushed
the
feature/kollect-aad
branch
from
November 22, 2022 02:14
6251eed to
a265f47
Compare
peterbom
marked this pull request as ready for review
November 22, 2022 02:16
FumingZhang
reviewed
Nov 22, 2022
FumingZhang
left a comment
FumingZhang
left a comment
Member
There was a problem hiding this comment.
LGTM, queued a pipeline to test the newly added test case.
Tatsat (Tats) Mishra 🐉 (Tatsinnit)
approved these changes
Nov 23, 2022
Tatsat (Tats) Mishra 🐉 (Tatsinnit)
left a comment
Tatsat (Tats) Mishra 🐉 (Tatsinnit)
left a comment
Member
There was a problem hiding this comment.
❤️☕️🙏 thanks for this addition, looks good to me as well.
Contributor
Author
FumingZhang: Pipeline is now passing |
Xing Zhou (zhoxing-ms)
approved these changes
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
kollectandkanalyzecommands attempted to gain cluster access by listing admin credentials. This does not work if the cluster has local accounts disabled.These changes make use of normal non-admin user credentials. However, if a cluster is AAD-enabled, these credentials will initially require interactive login. We can make use of
kubeloginto convert the credentials to allow non-interactive use. The bulk of the code changes here are to check whether this binary is accessible to the user and either downloading or failing with an appropriate error.cc: Tatsat (Tats) Mishra 🐉 (@Tatsinnit)
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.