Repository navigation
[AKS] Add NSG Control flags for az aks create / az aks nodepool add / az aks nodepool update - #5467
Merged
Merged
Conversation
ghost
requested review from
ZelinWang (wangzelin007) and
Xing Zhou (zhoxing-ms)
October 19, 2022 04:43
ghost
requested a review
from Yong Zhang (yonzhan)
October 19, 2022 04:43
Collaborator
|
AKS |
Jialun Cai (tsuiri)
marked this pull request as ready for review
October 20, 2022 01:51
Jialun Cai (tsuiri)
requested review from
FumingZhang and
Liming Liu (andyliuliming)
as code owners
October 20, 2022 01:51
FumingZhang
approved these changes
Oct 20, 2022
FumingZhang
left a comment
Member
There was a problem hiding this comment.
LGTM
Queued a pipeline to test newly added cases.
FumingZhang
reviewed
Oct 20, 2022
Contributor
Author
Queued another one for the latest commit. https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=62405154&view=results |
Xing Zhou (zhoxing-ms)
approved these changes
Oct 20, 2022
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=10100&view=results |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.