Repository navigation
[TA] change rolebinding create command parameter roles to comma-seperated - #5166
Merged
Merged
Conversation
Yitong Feng (YitongFeng-git)
requested review from
FumingZhang and
Liming Liu (andyliuliming)
as code owners
July 28, 2022 08:03
Yitong Feng (YitongFeng-git)
force-pushed
the
yife/binding
branch
from
July 28, 2022 08:09
db57646 to
8d14c8a
Compare
FumingZhang
approved these changes
Jul 28, 2022
FumingZhang
left a comment
FumingZhang
left a comment
Member
There was a problem hiding this comment.
LGTM
Please also update history.rst (and setup.py if you want to release a new version) and add some description about the change.
Also, since the feature is basically available, time to add a live test case for it?
Yitong Feng (YitongFeng-git)
changed the title
Contributor
Author
Updated history, and the tests will be added in August. |
Collaborator
|
AKS |
Yitong Feng (YitongFeng-git)
force-pushed
the
yife/binding
branch
from
August 18, 2022 03:11
f285e54 to
043f2f7
Compare
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
Xing Zhou (zhoxing-ms)
approved these changes
Aug 18, 2022
Amol Agrawal (pfrcks)
pushed a commit
to pfrcks/azure-cli-extensions
that referenced
this pull request
Dec 1, 2022
* [k8s-extension] Update extension CLI to v1.3.2 (Azure#5245) * [Release] Update index.json for extension [ k8s-extension ] Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1788975&view=results Last commit: Azure@203ec06 * [IoT] IoT Extension Release v0.17.0 (Azure#5249) * [TA] change rolebinding create command parameter roles to comma-seperated (Azure#5166) * Update `aks kollect` command to use Periscope version 0.0.10 (Azure#5248) * bump k8s-extension version to 1.3.3 Co-authored-by: Azure CLI Team <AzPyCLI@microsoft.com> Co-authored-by: Victoria Litvinova <73560279+vilit1@users.noreply.github.com> Co-authored-by: Yitong Feng <369397590@qq.com> Co-authored-by: peterbom <peter.bomber@microsoft.com> Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.Test: