Skip to content

Add az vm repair reset-nic command - #5117

Merged
Xing Zhou (zhoxing-ms) merged 10 commits into
Azure:mainfrom
swbae31:subae/AddResetNic
Jul 28, 2022
Merged

Xing Zhou (zhoxing-ms) merged 10 commits into
Azure:mainfrom
swbae31:subae/AddResetNic

Conversation

@swbae31

@swbae31 Sungwoo Bae (swbae31) commented Jul 13, 2022 •

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Added new command:
az vm repair reset-nic

Sample call:
az vm repair reset-nic -g -n --verbose

  • Adding as preview mode until next month CLI core release rolls out and the new 'az network vnet subnet list-available-ips' is available. (Current version uses 'az network vnet list-available-ips' and it might not work at all cases)

For easy testing run these in CLI:

  1. Open Cloud shell or Azure CLI console
  2. Run:
    az extension remove -n vm-repair
    az extension add --source https://azurecomputeaidrepair.blob.core.windows.net/test/vm_repair-0.4.4-py2.py3-none-any.whl

az vm repair reset-nic -g resource-group-name -n vm-name --verbose

General Guidelines

  • [V] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [V] Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

  • NOT a new extension

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost added the Auto-Assign Auto assign by bot label Jul 13, 2022
@ghost
ghost requested a review from ZelinWang (wangzelin007) July 13, 2022 22:46
@swbae31 Sungwoo Bae (swbae31) changed the title Subae/add reset nic Add az vm repair reset-nic command Jul 13, 2022
@ghost ghost added this to the Jul 2022 (2022-08-02) milestone Jul 13, 2022
@ghost ghost added the Compute label Jul 13, 2022
@yonzhan

Copy link
Copy Markdown
Collaborator

vm repair

@swbae31

Copy link
Copy Markdown
Contributor Author

Not sure why the Extensions index is failing. It is passing on local:
image

@zhoxing-ms

Xing Zhou (zhoxing-ms) commented Jul 15, 2022 •

Copy link
Copy Markdown
Contributor

Sungwoo Bae (@swbae31) This is a known issue, and it has been solved by PR #5119

@zhoxing-ms

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/vm-repair/azext_vm_repair/_help.py Outdated
Comment thread src/vm-repair/azext_vm_repair/_params.py Outdated
@zhoxing-ms

Copy link
Copy Markdown
Contributor

Could you write the description of PR change into the history notes HISTORY.rst?

@haagha Haider Agha (haagha) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sungwoo Bae (@swbae31) Adding my comments.

Comment thread src/vm-repair/azext_vm_repair/custom.py
Comment thread src/vm-repair/azext_vm_repair/custom.py
Comment thread src/vm-repair/azext_vm_repair/repair_utils.py
@swbae31

Copy link
Copy Markdown
Contributor Author

History updated.

@swbae31

Copy link
Copy Markdown
Contributor Author

@zhoxing-ms can this be merged now?

@zhoxing-ms
Xing Zhou (zhoxing-ms) merged commit e85a4e9 into Azure:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants